Re: [PATCH v4] staging: iio: ad2s1210: Switch to the gpio descriptor interface

[Nishad Kamdar <nishadkamdar@gmail.com>]

On Thu, Oct 25, 2018 at 08:43:56AM +0200, Slawomir Stepien wrote:
> On paź 24, 2018 20:20, Nishad Kamdar wrote:
> > Use the gpiod interface instead of the deprecated old non-descriptor
> > interface.
> > 
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > ---
> > Changes in v4:
> >  - Add spaces after { and before } in gpios[]
> >    initialization.
> >  - Check the correct pointer for error.
> >  - Align the dev_err msg to existing format in the code.
> > Changes in v3:
> >  - Use a pointer to pointer for gpio_desc in
> >    struct ad2s1210_gpio as it will be used to
> >    modify a pointer.
> >  - Use dot notation to initialize the structure.
> >  - Use a pointer variable to avoid writing gpios[i].
> > Changes in v2:
> >  - Use the spi_device struct embedded in st instead
> >    of passing it as an argument to ad2s1210_setup_gpios().
> >  - Use an array of structs to reduce redundant code in
> >    in ad2s1210_setup_gpios().
> >  - Remove ad2s1210_free_gpios() as devm API is being used.
> > ---
> >  drivers/staging/iio/resolver/ad2s1210.c | 92 ++++++++++++++-----------
> >  drivers/staging/iio/resolver/ad2s1210.h |  3 -
> >  2 files changed, 50 insertions(+), 45 deletions(-)
> 
> Looks good to me.
> 
> Reviewed-by: Slawomir Stepien <sst@poczta.fm>
> 
> -- 
> Slawomir Stepien
Hi,

Thanks for the review.

I was thinking of adding the device tree support to this file as well.

Can you please tell me if I can submit the new patch in a patchset with
this patch as the first and the one adding device tree support as the second?

Thanks and regards,
Nishad