From: Nathan Chancellor <natechancellor@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: vkoul@kernel.org, dan.j.williams@intel.com,
michal.simek@xilinx.com, dmaengine@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: xilinx_dma: Remove __aligned attribute on zynqmp_dma_desc_ll
Date: Thu, 25 Oct 2018 11:14:18 -0700 [thread overview]
Message-ID: <20181025181418.GA28946@flashbox> (raw)
In-Reply-To: <CAKwvOdn6juo_gfbEBmL2hanOuwbth2gE6bv9_O3AjWsM-WmsWA@mail.gmail.com>
On Thu, Oct 25, 2018 at 11:11:22AM -0700, Nick Desaulniers wrote:
> On Thu, Oct 25, 2018 at 11:06 AM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > Clang warns:
> >
> > drivers/dma/xilinx/zynqmp_dma.c:166:4: warning: attribute 'aligned' is
> > ignored, place it after "struct" to apply attribute to type declaration
> > [-Wignored-attributes]
> > }; __aligned(64)
> > ^
> > ./include/linux/compiler_types.h:200:38: note: expanded from macro
> > '__aligned'
> > #define __aligned(x) __attribute__((aligned(x)))
> > ^
> > 1 warning generated.
> >
> > As Nick pointed out in the previous version of this patch, the author
> > likely intended for this struct to be 8-byte (64-bit) aligned, not
> > 64-byte, which is the default. Remove the hanging __aligned attribute.
>
> Here was the v1 discussion, for reference.
> https://lkml.org/lkml/2018/9/12/4
>
> Thanks for sending the update Nathan. One thing I recommend doing is
> including the version in the [PATCH] subject line, ie. [PATCH v2].
> `git format-patch` can do this automatically for you, ex.
> $ git format-patch -v2 HEAD~
>
> >
> > Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver support")
> > Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> > Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> > ---
>
> Then below this line, you can include the notes about v1 -> v2
> changes. (interdiff notes to the reviewers that get discarded from the
> commit message). I think I've seen you use the versioning before, so
> sorry if I'm restating something you already know.
>
No, that's fine, I completely forgot all the versioning for this patch
as I was rushing, sorry about that!
> Thanks for the patch.
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
Thanks for the review!
Nathan
> > drivers/dma/xilinx/zynqmp_dma.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
> > index c74a88b65039..73de6a6179fc 100644
> > --- a/drivers/dma/xilinx/zynqmp_dma.c
> > +++ b/drivers/dma/xilinx/zynqmp_dma.c
> > @@ -163,7 +163,7 @@ struct zynqmp_dma_desc_ll {
> > u32 ctrl;
> > u64 nxtdscraddr;
> > u64 rsvd;
> > -}; __aligned(64)
> > +};
> >
> > /**
> > * struct zynqmp_dma_desc_sw - Per Transaction structure
> > --
> > 2.19.1
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
next prev parent reply other threads:[~2018-10-25 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 18:05 [PATCH] dmaengine: xilinx_dma: Remove __aligned attribute on zynqmp_dma_desc_ll Nathan Chancellor
2018-10-25 18:11 ` Nick Desaulniers
2018-10-25 18:14 ` Nathan Chancellor [this message]
2018-10-25 18:18 ` Nick Desaulniers
2018-11-24 13:41 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025181418.GA28946@flashbox \
--to=natechancellor@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=ndesaulniers@google.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).