From: Jonathan Cameron <jic23@kernel.org>
To: Matheus Tavares <matheus.bernardino@usp.br>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com
Subject: Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling
Date: Sun, 28 Oct 2018 16:52:02 +0000 [thread overview]
Message-ID: <20181028165202.52ee89b3@archlinux> (raw)
In-Reply-To: <20181027020005.3140-1-matheus.bernardino@usp.br>
On Fri, 26 Oct 2018 22:59:59 -0300
Matheus Tavares <matheus.bernardino@usp.br> wrote:
> This patch set adds scale info to ad2s90's single channel, improve
> error handling in it's functions and fix a possible race condition
> issue.
>
> The goal with this patch set is to address the points discussed in the
> mailing list in an effort to move ad2s90.c out of staging.
Thanks,
A good series in general. A few suggested improvements.
If I haven't commented on a patch, usually it means I'm happy with it
and will pick it up with the rest of the series.
Jonathan
>
> Changes in v2:
> - Added my S-o-B in patch 5.
>
> Matheus Tavares (5):
> staging:iio:ad2s90: Make read_raw return spi_read's error code
> staging:iio:ad2s90: Make probe handle spi_setup failure
> staging:iio:ad2s90: Remove always overwritten assignment
> staging:iio:ad2s90: Move device registration to the end of probe
> staging:iio:ad2s90: Check channel type at read_raw
>
> Victor Colombo (1):
> staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and
> read_raw
>
> drivers/staging/iio/resolver/ad2s90.c | 55 ++++++++++++++++++---------
> 1 file changed, 37 insertions(+), 18 deletions(-)
>
next prev parent reply other threads:[~2018-10-28 16:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 1:59 [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling Matheus Tavares
2018-10-27 2:00 ` [PATCH v2 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code Matheus Tavares
2018-10-28 16:40 ` Jonathan Cameron
2018-11-02 13:49 ` Matheus Tavares
2018-11-03 10:41 ` Jonathan Cameron
2018-10-27 2:00 ` [PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure Matheus Tavares
2018-10-28 16:43 ` Jonathan Cameron
2018-11-02 13:59 ` Matheus Tavares
2018-11-03 10:45 ` Jonathan Cameron
2018-10-27 2:00 ` [PATCH v2 3/6] staging:iio:ad2s90: Remove always overwritten assignment Matheus Tavares
2018-10-27 2:00 ` [PATCH v2 4/6] staging:iio:ad2s90: Move device registration to the end of probe Matheus Tavares
2018-10-27 2:00 ` [PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw Matheus Tavares
2018-10-28 16:50 ` Jonathan Cameron
2018-11-03 16:04 ` Matheus Tavares Bernardino
2018-11-03 17:26 ` Jonathan Cameron
2018-10-27 2:00 ` [PATCH v2 6/6] staging:iio:ad2s90: Check channel type at read_raw Matheus Tavares
2018-10-28 16:52 ` Jonathan Cameron [this message]
2018-10-30 16:57 ` [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling Matheus Tavares Bernardino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181028165202.52ee89b3@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matheus.bernardino@usp.br \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).