From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>,
Lee Jones <lee.jones@linaro.org>,
mturquette@baylibre.com, sboyd@kernel.org,
linus.walleij@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, lgirdwood@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar
Date: Thu, 1 Nov 2018 12:04:33 +0000 [thread overview]
Message-ID: <20181101120433.GC6425@sirena.org.uk> (raw)
In-Reply-To: <71938ce2-00da-8ee0-c010-58c2670ee327@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]
On Thu, Nov 01, 2018 at 11:40:01AM +0000, Richard Fitzgerald wrote:
> On 01/11/18 10:28, Charles Keepax wrote:
> > So pulling this out from earlier discussions in this thread,
> > it seems I can happily move all the child device registration
> > into device tree. I will also try this for the next version of
> > the patch, unless anyone wants to object? But it does change
> > the DT binding quite a lot as the individual sub drivers now
> > each require their own node rather than one single unified
> > Lochnagar node.
> We went through this discussion with the Madera MFD patches. I had
> originally implemented it using DT to register the child drivers and
> it was nice in some ways each driver having its own node. But Mark
> and Rob didn't like it so I went back to non-DT child registration with
> all sharing the parent MFD node. It would be nice if we could stick to
> one way of doing it so that Cirrus drivers don't flip-flop between
> different styles of DT binding.
The basic concern I have is encoding the current Linux idea of how to
split the subfunctions up into drivers into an ABI - the clocks in CODEC
drivers is the obvious example, they might want to be in the clock API
in future. If there's a very direct mapping onto individual hardware
blocks that worries me a lot less since it's more obviously reflecting
how the hardware is designed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-01 12:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 13:25 [PATCH v2 1/5] mfd: lochnagar: Add initial binding documentation Charles Keepax
2018-10-08 13:25 ` [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar Charles Keepax
2018-10-25 7:44 ` Lee Jones
2018-10-25 8:26 ` Charles Keepax
2018-10-25 9:28 ` Richard Fitzgerald
2018-10-25 10:12 ` Mark Brown
2018-10-25 10:56 ` Charles Keepax
2018-10-25 11:42 ` Lee Jones
2018-10-25 12:49 ` Charles Keepax
2018-10-25 13:20 ` Charles Keepax
2018-10-25 13:47 ` Richard Fitzgerald
2018-10-26 15:49 ` Mark Brown
2018-10-26 7:33 ` Lee Jones
2018-10-26 15:47 ` Mark Brown
2018-10-25 13:40 ` Richard Fitzgerald
2018-10-26 8:00 ` Lee Jones
2018-10-26 20:32 ` Mark Brown
2018-10-29 11:04 ` Lee Jones
2018-10-29 11:52 ` Richard Fitzgerald
2018-10-29 12:36 ` Richard Fitzgerald
2018-10-29 12:57 ` Mark Brown
2018-11-01 10:28 ` Charles Keepax
2018-11-01 11:40 ` Richard Fitzgerald
2018-11-01 12:04 ` Mark Brown [this message]
2018-11-01 12:01 ` Mark Brown
2018-11-01 14:17 ` Richard Fitzgerald
2018-10-08 13:25 ` [PATCH v2 3/5] clk: " Charles Keepax
2018-10-11 7:00 ` Stephen Boyd
2018-10-11 13:26 ` Charles Keepax
2018-10-12 15:59 ` Stephen Boyd
2018-10-15 10:49 ` Charles Keepax
2018-10-15 16:39 ` Stephen Boyd
2018-10-15 16:55 ` Mark Brown
2018-10-15 21:53 ` Stephen Boyd
2018-10-11 14:54 ` Mark Brown
2018-10-11 19:36 ` Stephen Boyd
2018-10-12 16:52 ` Mark Brown
2018-10-08 13:25 ` [PATCH v2 4/5] regulator: " Charles Keepax
2018-10-08 13:25 ` [PATCH v2 5/5] pinctrl: " Charles Keepax
2018-10-12 22:08 ` [PATCH v2 1/5] mfd: lochnagar: Add initial binding documentation Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101120433.GC6425@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).