Re: [PATCH RFC] hist lookups

From: Jiri Olsa <jolsa@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
	namhyung@kernel.org, jolsa@kernel.org
Subject: Re: [PATCH RFC] hist lookups
Date: Tue, 6 Nov 2018 12:51:21 +0100	[thread overview]
Message-ID: <20181106115121.GD3164@krava> (raw)
In-Reply-To: <20181105.194542.476367332910923203.davem@davemloft.net>

On Mon, Nov 05, 2018 at 07:45:42PM -0800, David Miller wrote:
> From: Jiri Olsa <jolsa@redhat.com>
> Date: Mon, 5 Nov 2018 21:34:47 +0100
> 
> > I pushed it in perf/fixes branch in:
> >   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> 
> Build fix for sparc below, I'm playing with this now.
> 
> perf: Use PRIu64 for printing top lost events count.
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>

will add this one, thanks

jirka

> 
> diff --git a/tools/perf/util/top.c b/tools/perf/util/top.c
> index db3413e..2c8eac8 100644
> --- a/tools/perf/util/top.c
> +++ b/tools/perf/util/top.c
> @@ -46,7 +46,7 @@ size_t perf_top__header_snprintf(struct perf_top *top, char *bf, size_t size)
>  							samples_per_sec;
>  		ret = SNPRINTF(bf, size,
>  			       "   PerfTop:%8.0f irqs/sec  kernel:%4.1f%%"
> -			       "  exact: %4.1f%% lost: %lu [", samples_per_sec,
> +			       "  exact: %4.1f%% lost: %" PRIu64 " [", samples_per_sec,
>  			       ksamples_percent, esamples_percent, top->lost);
>  	} else {
>  		float us_samples_per_sec = top->us_samples / top->delay_secs;