On Tue, Nov 06, 2018 at 07:21:41PM +0100, Geert Uytterhoeven wrote: > > +#include > Is this sufficient? > include/asm-generic/pci_iomap.h provides the dummies if CONFIG_PCI=n and > CONFIG_GENERIC_PCI_IOMAP=y, while arch/sh/Kconfig selects GENERIC_PCI_IOMAP > only if PCI is enabled. Hence it's not set in the failing config > (sh/allyesconfig). Ah, possibly not - IIRC I minimized the config when testing but I could've got the GENERIC_PCI_IOMAP=y. > Probably SH should select GENERIC_PCI_IOMAP unconditionally, like most other > architectures do (alpha and powerpc select it conditionally, though)? I'd be surprised if it had a strong reason not to.