From: David Miller <davem@davemloft.net>
To: robh@kernel.org
Cc: frowand.list@gmail.com, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH 2/8] of: Drop full path from Sparc PDT full_name
Date: Thu, 08 Nov 2018 19:11:16 -0800 (PST) [thread overview]
Message-ID: <20181108.191116.1317160901826988583.davem@davemloft.net> (raw)
In-Reply-To: <20181107223151.14991-3-robh@kernel.org>
From: Rob Herring <robh@kernel.org>
Date: Wed, 7 Nov 2018 16:31:45 -0600
> @@ -32,24 +32,7 @@ unsigned int of_pdt_unique_id __initdata;
>
> static char * __init of_pdt_build_full_name(struct device_node *dp)
> {
> - int len, ourlen, plen;
> - char *n;
> -
> - dp->path_component_name = build_path_component(dp);
> -
> - plen = strlen(dp->parent->full_name);
> - ourlen = strlen(dp->path_component_name);
> - len = ourlen + plen + 2;
> -
> - n = prom_early_alloc(len);
> - strcpy(n, dp->parent->full_name);
> - if (!of_node_is_root(dp->parent)) {
> - strcpy(n + plen, "/");
> - plen++;
> - }
> - strcpy(n + plen, dp->path_component_name);
> -
> - return n;
> + return build_path_component(dp);
> }
>
> #else /* CONFIG_SPARC */
Hmmm, shouldn't this be doing what the non-SPARC version of
of_pdt_build_full_name() does which is to return the component string
appended to the parent's full_name?
You're just returning the component string here.
next prev parent reply other threads:[~2018-11-09 3:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 22:31 [PATCH 0/8] sparc: OF name and device_type rework Rob Herring
2018-11-07 22:31 ` [PATCH 1/8] fs/openpromfs: use full_name instead of path_component_name Rob Herring
2018-11-07 22:31 ` [PATCH 2/8] of: Drop full path from Sparc PDT full_name Rob Herring
2018-11-09 3:11 ` David Miller [this message]
2018-11-09 20:30 ` Rob Herring
2018-11-10 4:36 ` David Miller
2018-11-07 22:31 ` [PATCH 3/8] sparc: prom: use property "name" directly to construct node names Rob Herring
2018-11-09 3:13 ` David Miller
2018-11-09 13:02 ` Rob Herring
2018-11-10 0:32 ` David Miller
2018-11-07 22:31 ` [PATCH 4/8] sparc: Convert to using %pOF instead of full_name Rob Herring
2018-11-07 22:31 ` [PATCH 5/8] sparc: Convert to using %pOFn instead of device_node.name Rob Herring
2018-11-07 22:31 ` [PATCH 6/8] sparc: Use of_node_name_eq for node name comparisons Rob Herring
2018-11-07 22:31 ` [PATCH 7/8] sparc: Remove unused leon_trans_init Rob Herring
2018-11-07 22:31 ` [PATCH 8/8] sparc: Use device_type helpers to access the node type Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108.191116.1317160901826988583.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).