From: Shawn Guo <shawn.guo@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Sriharsha Allenki <sallenki@codeaurora.org>,
Anu Ramanathan <anur@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add Qualcomm Synopsys High-Speed USB PHY binding
Date: Fri, 9 Nov 2018 14:31:37 +0800 [thread overview]
Message-ID: <20181109063134.GA20049@tiger> (raw)
In-Reply-To: <20181109050819.GK12092@vkoul-mobl>
On Fri, Nov 09, 2018 at 10:38:19AM +0530, Vinod Koul wrote:
> On 08-11-18, 15:04, Shawn Guo wrote:
> > From: Sriharsha Allenki <sallenki@codeaurora.org>
> >
> > It adds bindings for Synopsys 28nm femto phy controller that supports
> > LS/FS/HS usb connectivity on Qualcomm chipsets.
> >
> > Signed-off-by: Sriharsha Allenki <sallenki@codeaurora.org>
> > Signed-off-by: Anu Ramanathan <anur@codeaurora.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > ---
> > .../phy/qcom,snps-28nm-usb-hs-phy.txt | 101 ++++++++++++++++++
> > 1 file changed, 101 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/phy/qcom,snps-28nm-usb-hs-phy.txt
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-28nm-usb-hs-phy.txt b/Documentation/devicetree/bindings/phy/qcom,snps-28nm-usb-hs-phy.txt
> > new file mode 100644
> > index 000000000000..75e7a09dd558
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/qcom,snps-28nm-usb-hs-phy.txt
> > @@ -0,0 +1,101 @@
> > +Qualcomm Synopsys 28nm Femto phy controller
> > +===========================================
> > +
> > +Synopsys 28nm femto phy controller supports LS/FS/HS usb connectivity on
> > +Qualcomm chipsets.
> > +
> > +Required properties:
> > +
> > +- compatible:
> > + Value type: <string>
> > + Definition: Should contain "qcom,usb-snps-hsphy".
> > +
> > +- reg:
> > + Value type: <prop-encoded-array>
> > + Definition: USB PHY base address and length of the register map.
> > +
> > +- #phy-cells:
> > + Value type: <u32>
> > + Definition: Should be 0.
>
> I dont quite understand the definition that it should be 0, maybe you
> mean allowed value is 0, if so why have this property?
The property is defined by generic phy bindings phy/phy-bindings.txt.
I can add a pointer to it if you think that's necessary. The property
should be 0 for our device, because there is zero number cell in phy
specifier from dwc3 node as shown in the example.
dwc3@78c0000 {
...
phys = <&usb2_phy_prim>;
phy-names = "usb2-phy";
}
And for that reason, we can use the generic .of_xlate implementation
of_phy_simple_xlate() provided by phy core. There are some comments
in kernel doc of of_phy_simple_xlate() which might be helpful.
Shawn
next prev parent reply other threads:[~2018-11-09 6:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 7:04 [PATCH 0/2] Add Synopsys High-Speed USB PHY driver for Qualcomm SoCs Shawn Guo
2018-11-08 7:04 ` [PATCH 1/2] dt-bindings: phy: Add Qualcomm Synopsys High-Speed USB PHY binding Shawn Guo
2018-11-09 5:08 ` Vinod Koul
2018-11-09 6:31 ` Shawn Guo [this message]
2018-11-09 11:06 ` Vinod Koul
[not found] ` <5bea0ed8.1c69fb81.8715.38b2@mx.google.com>
2018-11-13 3:42 ` Shawn Guo
2018-11-13 4:59 ` Shawn Guo
2018-11-17 15:13 ` Rob Herring
2018-11-19 6:55 ` Shawn Guo
2018-11-19 7:10 ` Vivek Gautam
2018-11-19 9:15 ` Shawn Guo
2018-11-08 7:04 ` [PATCH 2/2] phy: qualcomm: Add Synopsys High-Speed USB PHY driver Shawn Guo
2018-11-09 5:22 ` Vinod Koul
2018-11-09 6:52 ` Shawn Guo
2018-11-09 11:08 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109063134.GA20049@tiger \
--to=shawn.guo@linaro.org \
--cc=anur@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sallenki@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).