From: Johan Hovold <johan@kernel.org>
To: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Cc: Johan Hovold <johan@kernel.org>,
marcel@holtmann.org, johan.hedberg@gmail.com, mka@chromium.org,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org,
Johan Hovold <jhovold@gmail.com>
Subject: Re: [PATCH v1 1/4] Bluetooth: hci_qca: use wait_until_sent() for power pulses
Date: Fri, 16 Nov 2018 10:47:24 +0100 [thread overview]
Message-ID: <20181116094724.GO19900@localhost> (raw)
In-Reply-To: <e2362ad539463a3a139419b93ccca831@codeaurora.org>
On Thu, Nov 15, 2018 at 08:04:29PM +0530, Balakrishna Godavarthi wrote:
> Hi Johan,
>
> On 2018-11-14 20:57, Johan Hovold wrote:
> > On Tue, Nov 06, 2018 at 05:35:25PM +0530, Balakrishna Godavarthi wrote:
> >> wcn3990 requires a power pulse to turn ON/OFF along with
> >> regulators. Sometimes we are observing the power pulses are sent
> >> out with some time delay, due to queuing these commands. This is
> >> causing synchronization issues with chip, which intern delay the
> >> chip setup or may end up with communication issues.
> >>
> >> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> >> ---
> >> drivers/bluetooth/hci_qca.c | 22 +++++++++-------------
> >> 1 file changed, 9 insertions(+), 13 deletions(-)
> >>
> >> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> >> index f72ded4ec9ae..051f081d1835 100644
> >> --- a/drivers/bluetooth/hci_qca.c
> >> +++ b/drivers/bluetooth/hci_qca.c
> >> @@ -1016,8 +1016,7 @@ static inline void host_set_baudrate(struct
> >> hci_uart *hu, unsigned int speed)
> >> static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)
> >> {
> >> struct hci_uart *hu = hci_get_drvdata(hdev);
> >> - struct qca_data *qca = hu->priv;
> >> - struct sk_buff *skb;
> >> + int ret;
> >>
> >> /* These power pulses are single byte command which are sent
> >> * at required baudrate to wcn3990. On wcn3990, we have an external
> >> @@ -1030,18 +1029,14 @@ static int qca_send_power_pulse(struct hci_dev
> >> *hdev, u8 cmd)
> >> * sending power pulses to SoC.
> >> */
> >> bt_dev_dbg(hdev, "sending power pulse %02x to SoC", cmd);
> >> -
> >> - skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL);
> >> - if (!skb)
> >> - return -ENOMEM;
> >> -
> >> hci_uart_set_flow_control(hu, true);
> >> + ret = serdev_device_write(hu->serdev, &cmd, sizeof(cmd), 0);
> >
> > Don't you want a non-zero timeout here? Otherwise you might as well
> > call serdev_device_write() directly.
>
> [Bala]: we need an in definite timeout for these commands. will use
> HCI_UART_TX_WAKEUP.
>
> > Also have you made sure that serdev_device_write_wakeup() is called in
> > the drivers write-wakeup callback as serdev_device_write() requires?
> >
> > See this series in case what you really wanted was to wait indefinitely
> > (you can use MAX_SCHEDULE_TIMEOUT):
> >
> > https://lkml.kernel.org/r/<20181114150904.19653-1-johan@kernel.org>
>
> [Bala]: thanks for pointers. from
> https://lore.kernel.org/patchwork/patch/1012358/
> it was clear to me that i need call below functions in order to
> wait until full data is sent.
>
> serdev_device_write_wakeup()
> serdev_device_write()
> serdev_device_wait_until_sent()
>
> correct me whether my understanding is correct.
No, serdev_device_write_wakeup() needs to be called from the serdev
driver's write_wakeup() callback (as defined in struct struct
serdev_device_ops).
Either use serdev_device_write_wakeup() as the callback, or call it from
your driver's custom write_wakeup() callback.
Hmm, I see now that the callbacks are set in hci_uart_register_device()
to hci_serdev_client_ops, which is shared by all serdev BT drivers. You
may be able to just add the call to the callback defined there so that
all Bluetooth drivers can use serdev_device_write().
Johan
next prev parent reply other threads:[~2018-11-16 9:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 12:05 Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
2018-11-06 12:05 ` [PATCH v1 1/4] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
2018-11-14 0:17 ` Matthias Kaehlcke
2018-11-14 6:29 ` Balakrishna Godavarthi
2018-11-14 15:27 ` Johan Hovold
2018-11-15 14:34 ` Balakrishna Godavarthi
2018-11-16 9:47 ` Johan Hovold [this message]
2018-11-06 12:05 ` [PATCH v1 2/4] Bluetooth: hci_qca: Pull RTS line high for baudrate change command Balakrishna Godavarthi
2018-11-14 1:55 ` Matthias Kaehlcke
2018-11-14 6:32 ` Balakrishna Godavarthi
2018-11-06 12:05 ` [PATCH v1 3/4] Bluetooth: hci_qca: clear HCI_QUIRK_RESET_ON_CLOSE flag Balakrishna Godavarthi
2018-11-06 12:33 ` Marcel Holtmann
2018-11-06 12:44 ` Balakrishna Godavarthi
2018-11-06 13:02 ` Marcel Holtmann
2018-11-06 13:14 ` Balakrishna Godavarthi
2018-11-06 13:36 ` Balakrishna Godavarthi
2018-11-14 7:48 ` Marcel Holtmann
2018-11-14 13:37 ` Balakrishna Godavarthi
2018-11-14 2:14 ` Matthias Kaehlcke
2018-11-14 6:50 ` Balakrishna Godavarthi
2018-11-06 12:05 ` [PATCH v1 4/4] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Balakrishna Godavarthi
2018-11-14 19:36 ` Matthias Kaehlcke
2018-11-15 11:40 ` Balakrishna Godavarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116094724.GO19900@localhost \
--to=johan@kernel.org \
--cc=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=jhovold@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).