From: Minchan Kim <minchan@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Hannes Reinecke <hare@suse.com>,
Howard Chen <howardsoc@google.com>
Subject: Re: [PATCH] zram: close udev startup race condition as default groups
Date: Fri, 16 Nov 2018 07:48:20 -0800 [thread overview]
Message-ID: <20181116154820.GA255402@google.com> (raw)
In-Reply-To: <20181115174504.GJ95254@sasha-vm>
On Thu, Nov 15, 2018 at 12:45:04PM -0500, Sasha Levin wrote:
> On Wed, Nov 14, 2018 at 02:52:23PM +0900, Minchan Kim wrote:
> > commit fef912bf860e upstream.
> > commit 98af4d4df889 upstream.
> >
> > I got a report from Howard Chen that he saw zram and sysfs race(ie,
> > zram block device file is created but sysfs for it isn't yet)
> > when he tried to create new zram devices via hotadd knob.
> >
> > v4.20 kernel fixes it by [1, 2] but it's too large size to merge
> > into -stable so this patch fixes the problem by registering defualt
> > group by Greg KH's approach[3].
> >
> > This patch should be applied to every stable tree [3.16+] currently
> > existing from kernel.org because the problem was introduced at 2.6.37
> > by [4].
> >
> > [1] fef912bf860e, block: genhd: add 'groups' argument to device_add_disk
> > [2] 98af4d4df889, zram: register default groups with device_add_disk()
> > [3] http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/
> > [4] 33863c21e69e9, Staging: zram: Replace ioctls with sysfs interface
> >
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Cc: Hannes Reinecke <hare@suse.com>
> > Tested-by: Howard Chen <howardsoc@google.com>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
>
> I've queued this for 4.19 and 4.18, but it doesn't apply to anything
> older than that.
Thanks for the review, Hannes.
Sasha, I will send separate patches for older stable kernel.
Thanks for picking the patch.
>
> --
> Thanks,
> Sasha
next prev parent reply other threads:[~2018-11-16 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 5:52 [PATCH] zram: close udev startup race condition as default groups Minchan Kim
2018-11-14 7:09 ` Hannes Reinecke
2018-11-15 17:45 ` Sasha Levin
2018-11-16 15:48 ` Minchan Kim [this message]
2018-11-23 6:25 ` [PATCH for v4.14] " Minchan Kim
2018-11-23 18:50 ` Sasha Levin
2018-11-23 6:28 ` [PATCH for 4.9] " Minchan Kim
2018-11-23 6:30 ` [PATCH] [PATCH for v4.4] " Minchan Kim
2018-11-23 6:30 ` [PATCH] [PATCH for v3.18] " Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116154820.GA255402@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hare@suse.com \
--cc=howardsoc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).