From: Rob Herring <robh@kernel.org>
To: Florian Eckert <fe@dev.tdt.de>
Cc: jdelvare@suse.com, linux@roeck-us.net, mark.rutland@arm.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] hwmon: (adcxx) add devictree bindings documentation
Date: Sat, 17 Nov 2018 08:40:41 -0600 [thread overview]
Message-ID: <20181117144040.GA8016@bogus> (raw)
In-Reply-To: <20181115135013.30723-2-fe@dev.tdt.de>
On Thu, Nov 15, 2018 at 02:50:12PM +0100, Florian Eckert wrote:
> Document the devicetree bindings for the adcxx.
>
> Signed-off-by: Florian Eckert <fe@dev.tdt.de>
> ---
> Documentation/devicetree/bindings/hwmon/adcxx.txt | 24 +++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/adcxx.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adcxx.txt b/Documentation/devicetree/bindings/hwmon/adcxx.txt
> new file mode 100644
> index 000000000000..a94a5fe21b6d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adcxx.txt
> @@ -0,0 +1,24 @@
> +adcxx properties
Needs a better description of what this h/w is.
ADCs go in iio/adc/
> +
> +Required properties:
> +- compatible: Must be one of the following:
> + - "national,adcxx1s" for adcxx1s
> + - "national,adcxx2s" for adcxx2s
> + - "national,adcxx4s" for adcxx4s
> + - "national,adcxx8s" for adcxx8s
Don't use wildcards in compatible strings.
> +- reg: SPI address for chip
> +
> +Optional properties:
> +
> +- vref-supply
> + The external reference in microvolt for this device is set to this value.
> + If it does not exists the reference will be set to 3300000uV (3.3V).
> +
> +Example:
> +
> +adc@6 {
> + compatible = "national,adcxx2s";
> + reg = <6 0>;
? SPI addresses are a single cell.
> + spi-max-frequency = <1000000>;
> + vref-supply = <&vref>;
> +};
> --
> 2.11.0
>
next prev parent reply other threads:[~2018-11-17 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 13:50 [PATCH v3 0/2] hwmon: Add device tree support for adcxx Florian Eckert
2018-11-15 13:50 ` [PATCH v3 1/2] hwmon: (adcxx) add devictree bindings documentation Florian Eckert
2018-11-17 14:40 ` Rob Herring [this message]
2018-11-19 1:25 ` Guenter Roeck
2018-11-20 7:16 ` Florian Eckert
2018-11-15 13:50 ` [PATCH v3 2/2] hwmon: (adcxx) Add device tree support Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181117144040.GA8016@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fe@dev.tdt.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).