From: Borislav Petkov <bp@alien8.de>
To: Dave Young <dyoung@redhat.com>, lijiang <lijiang@redhat.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
x86@kernel.org, tglx@linutronix.de, mingo@redhat.com,
akpm@linux-foundation.org, bhe@redhat.com
Subject: Re: [PATCH 1/2 v6] x86/kexec_file: add e820 entry in case e820 type string matches to io resource name
Date: Mon, 19 Nov 2018 11:28:12 +0100 [thread overview]
Message-ID: <20181119102812.GA14688@zn.tnic> (raw)
In-Reply-To: <20181119095515.GC14045@dhcp-128-65.nay.redhat.com>
On Mon, Nov 19, 2018 at 05:55:15PM +0800, Dave Young wrote:
> Another thing is it is not worth to get the exact info, the 1st kernel
> reserved part is just fine to be reserved as well in 2nd kernel, no
> side effects. Actually there might be some obscure use cases we
> do not find which rely those reserved memory ranges so it is better to
> have.
That makes sense as an argument. The cleaner thing would be to figure
out only *which* ranges we're going to need but that is probably harder
than simply exporting what the first kernel sees. But why we're doing
it, needs to be in the commit message so that it is clear when bug
hunting later.
...
> The basic problem is that this device is in PCI segment 1 and
> the kernel PCI probing cannot find it without all the e820 i/o
> reservations being present in the e820 table. And the crash kernel
> does not have those reservations because the kexec command does not
> pass i/o reservation via the memmap= command line option. (This
> problem does not show up for other vendors, as SGI is apparently the
> only one using extended PCI. The lookup of devices in PCI segment 0
> actually fails for everyone, but devices in segment 0 are then found
> by some legacy lookup method.) The workaround for this is to fix kexec
> to pass i/o reserved areas to the crash kernel.
Yap, this is the *why* I'm looking for. Lianbo, in your next submission,
please add Dave's explanations to your commit messages.
If it says "we need to do X" in the commit message, without a reason
given *why* we need to, then there's no way for us to know *why* we did
it, when looking at this months from now. And we absolutely need the
*why* when staring at the code and fixing the next bug/issue.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-11-19 10:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 7:29 [PATCH 0/2 v6] add reserved e820 ranges to the kdump kernel e820 table Lianbo Jiang
2018-11-14 7:29 ` [PATCH 1/2 v6] x86/kexec_file: add e820 entry in case e820 type string matches to io resource name Lianbo Jiang
2018-11-14 11:26 ` Borislav Petkov
2018-11-15 5:44 ` lijiang
2018-11-15 5:58 ` Dave Young
2018-11-16 1:34 ` lijiang
2018-11-15 10:39 ` Borislav Petkov
2018-11-16 3:25 ` lijiang
2018-11-18 11:52 ` Borislav Petkov
2018-11-20 4:07 ` lijiang
2018-11-21 10:54 ` lijiang
2018-11-21 13:06 ` Boris Petkov
2018-11-19 9:55 ` Dave Young
2018-11-19 10:28 ` Borislav Petkov [this message]
2018-11-20 3:37 ` lijiang
2018-11-20 19:29 ` Borislav Petkov
2018-11-20 20:43 ` Bjorn Helgaas
2018-11-21 18:42 ` Borislav Petkov
2018-11-14 7:29 ` [PATCH 2/2 v6] x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table Lianbo Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119102812.GA14688@zn.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=helgaas@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).