From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: hch@lst.de, konrad.wilk@oracle.com, m.szyprowski@samsung.com,
john.stultz@linaro.org, iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] swiotlb: Skip cache maintenance on map error
Date: Tue, 20 Nov 2018 17:07:53 +0100 [thread overview]
Message-ID: <20181120160753.GB2492@lst.de> (raw)
In-Reply-To: <a77c838eb070fb46c51802aa22c28bd8e1f9741c.1542722463.git.robin.murphy@arm.com>
On Tue, Nov 20, 2018 at 02:09:53PM +0000, Robin Murphy wrote:
> If swiotlb_bounce_page() failed, calling arch_sync_dma_for_device() may
> lead to such delights as performing cache maintenance on whatever
> address phys_to_virt(SWIOTLB_MAP_ERROR) looks like, which is typically
> outside the kernel memory map and goes about as well as expected.
>
> Don't do that.
>
> Fixes: a4a4330db46a ("swiotlb: add support for non-coherent DMA")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-11-20 16:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 14:09 [PATCH 0/2] SWIOTLB fixes for 4.20 Robin Murphy
2018-11-20 14:09 ` [PATCH 1/2] swiotlb: Make DIRECT_MAPPING_ERROR viable Robin Murphy
2018-11-20 14:49 ` Konrad Rzeszutek Wilk
2018-11-20 15:01 ` Robin Murphy
2018-11-20 16:34 ` Konrad Rzeszutek Wilk
2018-11-20 16:07 ` Christoph Hellwig
2018-11-20 14:09 ` [PATCH 2/2] swiotlb: Skip cache maintenance on map error Robin Murphy
2018-11-20 14:49 ` Konrad Rzeszutek Wilk
2018-11-20 16:07 ` Christoph Hellwig [this message]
2018-11-20 16:08 ` [PATCH 0/2] SWIOTLB fixes for 4.20 Christoph Hellwig
2018-11-20 16:34 ` Konrad Rzeszutek Wilk
2018-11-21 13:03 ` Christoph Hellwig
2018-11-21 15:11 ` Konrad Rzeszutek Wilk
2018-11-27 19:07 ` Stefano Stabellini
2018-11-27 20:39 ` Stefano Stabellini
2018-11-20 19:24 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120160753.GB2492@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=john.stultz@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).