From: Mark Brown <broonie@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Evan Green <evgreen@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
digetx@gmail.com, ryandcase@chromium.org,
David Collins <collinsd@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] regulator: core: Remove loop disabling supplies in regulator_force_disable()
Date: Tue, 20 Nov 2018 16:25:04 +0000 [thread overview]
Message-ID: <20181120162504.GJ3894@sirena.org.uk> (raw)
In-Reply-To: <CAD=FV=UHiwjt2a8GFZKG3ZrRfjTgQDWD_mZu_qZP7Ve-HNTMYg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]
On Tue, Nov 20, 2018 at 08:04:57AM -0800, Doug Anderson wrote:
> In general it's hard for me to reason about how the system in general
> should behave after regulator_force_disable() is called. Is it
> basically expected that the system will panic soon after?
> Specifically other consumers of the same regulator will think it's on
> but it won't actually be on. What should happen if one of those other
> consumers calls disable/enable? Should the regulator turn back on?
> ...or is the regulator permanently off until the system reboots?
If something has been forced off the system is in very serious trouble
and had a cricial safety problem, though the fact that there's error
handling code that did the force disable might mean that there's some
ability to recover the situation - for example, this might be part of
thermal management or something like charger management. Other drivers
do get notified if something gets forced off so a well written system
will ensure that other users of a regulator that can get force disabled
will have handling for this as should userspace. We don't have any such
full systems in mainline, though - it is a really uncommon case.
The usage in the Adreno drivers just looks to be another completely
out of expectation regulator API usage in the QC code. I do wish there
were a way to flag API calls as needing review :(
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-20 16:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 0:26 [PATCH 1/7] regulator: core: Properly expose requested_microamps in sysfs Douglas Anderson
2018-11-20 0:26 ` [PATCH 2/7] regulator: core: Don't assume always_on when is_enabled returns err Douglas Anderson
2018-11-20 16:00 ` Mark Brown
2018-11-20 18:17 ` Doug Anderson
2018-11-20 0:26 ` [PATCH 3/7] regulator: core: Don't double-disable supplies in regulator_disable_deferred() Douglas Anderson
2018-11-20 0:45 ` Dmitry Osipenko
2018-11-20 0:26 ` [PATCH 4/7] regulator: core: Only count load for enabled consumers Douglas Anderson
2018-11-20 0:26 ` [PATCH 5/7] regulator: core: add enable_count for consumers to debug fs Douglas Anderson
2018-11-20 16:10 ` Mark Brown
2018-11-20 16:52 ` Doug Anderson
2018-11-20 16:58 ` Mark Brown
2018-11-20 17:05 ` Doug Anderson
2018-11-20 17:57 ` Doug Anderson
2018-11-20 0:26 ` [PATCH 6/7] regulator: core: Avoid propagating to supplies when possible Douglas Anderson
2018-11-20 0:26 ` [PATCH 7/7] regulator: core: Remove loop disabling supplies in regulator_force_disable() Douglas Anderson
2018-11-20 0:58 ` Dmitry Osipenko
2018-11-20 2:05 ` Doug Anderson
2018-11-20 15:54 ` Mark Brown
2018-11-20 16:04 ` Doug Anderson
2018-11-20 16:25 ` Mark Brown [this message]
2018-11-20 16:57 ` Doug Anderson
2018-11-20 16:59 ` Mark Brown
2018-11-20 17:00 ` Mark Brown
2018-11-20 17:55 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120162504.GJ3894@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=dianders@chromium.org \
--cc=digetx@gmail.com \
--cc=evgreen@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ryandcase@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).