From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
vkoul@kernel.org, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
tony@atomide.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1
Date: Fri, 23 Nov 2018 20:52:15 +0200 [thread overview]
Message-ID: <20181123185215.GH12912@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <6ed280af-edb6-4be7-82f4-7fc00378103e@ti.com>
Hi,
On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote:
> On 22/11/2018 17.12, Russell King - ARM Linux wrote:
> > I'm also not sure about this:
> >
> > if (cpu_is_omap15xx())
> > end++;
> >
> > in dma_dest_len() - is that missing from the omap-dma driver? It looks
> > like a work-around for some problem on OMAP15xx, but I can't make sense
> > about why it's in the UDC driver rather than the legacy DMA driver.
>
> afaik no other legacy drivers were doing similar thing, this must be
> something which is needed for the omap_udc driver to fix up something?
Here's the patch that added it: https://marc.info/?l=linux-omap&m=119634396324221&w=2
"Make DMA-OUT behave on the 1510 ... the 1510 CPC register was just
off-by-one with respect to the 1611 CDAC"
A.
next prev parent reply other threads:[~2018-11-23 18:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:40 [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1 Peter Ujfalusi
2018-11-19 18:46 ` Aaro Koskinen
2018-11-20 7:28 ` Peter Ujfalusi
2018-11-20 21:04 ` Aaro Koskinen
2018-11-22 8:31 ` Peter Ujfalusi
2018-11-22 22:01 ` Aaro Koskinen
2018-11-23 11:45 ` Peter Ujfalusi
2018-11-24 0:17 ` Aaro Koskinen
2018-11-24 17:48 ` Russell King - ARM Linux
2018-11-24 19:06 ` Aaro Koskinen
2018-11-24 19:29 ` Russell King - ARM Linux
2018-11-22 10:29 ` Russell King - ARM Linux
2018-11-22 15:12 ` Russell King - ARM Linux
2018-11-22 22:24 ` Aaro Koskinen
2018-11-23 0:25 ` Russell King - ARM Linux
2018-11-23 1:23 ` Aaro Koskinen
2018-11-23 11:54 ` Peter Ujfalusi
2018-11-23 12:35 ` Peter Ujfalusi
2018-11-23 15:43 ` Russell King - ARM Linux
2018-11-23 16:16 ` Russell King - ARM Linux
2018-11-23 23:27 ` Russell King - ARM Linux
2018-11-23 18:52 ` Aaro Koskinen [this message]
2018-11-24 20:09 ` Russell King - ARM Linux
2018-11-25 1:07 ` Tony Lindgren
2018-11-25 1:11 ` Tony Lindgren
2018-11-25 11:11 ` Russell King - ARM Linux
2018-11-25 11:57 ` Russell King - ARM Linux
2018-11-25 16:58 ` Aaro Koskinen
2018-11-25 17:14 ` Tony Lindgren
2018-12-17 23:47 ` Aaro Koskinen
2018-12-18 15:55 ` Tony Lindgren
2018-12-17 19:16 ` Aaro Koskinen
2018-12-18 10:11 ` Peter Ujfalusi
2018-11-23 11:49 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123185215.GH12912@darkstar.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).