From: Joe Lawrence <joe.lawrence@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
linux-arch@vger.kernel.org,
Joel Fernandes <joel@joelfernandes.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [for-next][PATCH 00/18] function_graph: Add separate depth counter to prevent trace corruption
Date: Wed, 28 Nov 2018 15:39:31 -0500 [thread overview]
Message-ID: <20181128203931.ym2rkya7a6agzzy3@redhat.com> (raw)
In-Reply-To: <20181122002801.501220343@goodmis.org>
On Wed, Nov 21, 2018 at 07:28:01PM -0500, Steven Rostedt wrote:
>
> [ ... snip ... ]
>
> Feel free to test this! I'll be pushing this to linux-next and let it
> sit there a week or so before pushing it to Linus.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> ftrace/urgent
Hi Steve,
With your ftrace/urgent branch linked above, if I try a quick
function_graph test like the following:
SYSFS=/sys/kernel/debug/tracing
echo 0 > "$SYSFS/tracing_on"
echo cmdline_proc_show > "$SYSFS/set_graph_function"
echo function_graph > "$SYSFS/current_tracer"
echo 1 > "$SYSFS/tracing_on"
I see a bunch of scheduler interrupt functions in the trace/trace_pipe
without even invoking cmdline_proc_show().
This tests works as expected with Linux 4.20-rc3 though:
% cat /sys/kernel/debug/tracing/trace_pipe
2) | cmdline_proc_show() {
2) 0.320 us | seq_puts();
2) 0.030 us | seq_putc();
2) 1.352 us | }
Operator error, or did the patchset break something?
Regards,
-- Joe
next prev parent reply other threads:[~2018-11-28 20:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 0:28 [for-next][PATCH 00/18] function_graph: Add separate depth counter to prevent trace corruption Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 01/18] function_graph: Create function_graph_enter() to consolidate architecture code Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 02/18] x86/function_graph: Simplify with function_graph_entry() Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 03/18] ARM: function_graph: " Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 04/18] arm64: " Steven Rostedt
2018-11-27 18:07 ` Will Deacon
2018-11-27 18:26 ` Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 05/18] microblaze: " Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 06/18] MIPS: " Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 07/18] nds32: " Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 08/18] parisc: " Steven Rostedt
[not found] ` <20181123073033.2083020863@mail.kernel.org>
2018-11-23 9:06 ` Helge Deller
2018-11-23 17:12 ` Steven Rostedt
2018-11-23 18:34 ` Sasha Levin
2018-11-23 19:26 ` Steven Rostedt
2018-11-23 20:00 ` Sasha Levin
2018-11-24 18:46 ` Steven Rostedt
2018-12-03 14:54 ` Sasha Levin
2018-11-22 0:28 ` [for-next][PATCH 09/18] powerpc/function_graph: " Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 10/18] riscv/function_graph: " Steven Rostedt
2018-11-26 16:47 ` Palmer Dabbelt
2018-11-22 0:28 ` [for-next][PATCH 11/18] s390/function_graph: " Steven Rostedt
2018-11-22 6:43 ` Martin Schwidefsky
2018-11-23 17:15 ` Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 12/18] sh/function_graph: " Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 13/18] sparc/function_graph: " Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 14/18] function_graph: Make ftrace_push_return_trace() static Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 15/18] function_graph: Use new curr_ret_depth to manage depth instead of curr_ret_stack Steven Rostedt
2018-11-22 10:03 ` Peter Zijlstra
2018-11-23 14:14 ` Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 16/18] function_graph: Move return callback before update " Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 17/18] function_graph: Reverse the order of pushing the ret_stack and the callback Steven Rostedt
2018-11-22 0:28 ` [for-next][PATCH 18/18] function_graph: Have profiler use curr_ret_stack and not depth Steven Rostedt
2018-11-26 5:15 ` [for-next][PATCH 00/18] function_graph: Add separate depth counter to prevent trace corruption Masami Hiramatsu
2018-11-28 20:39 ` Joe Lawrence [this message]
2018-11-28 21:00 ` Steven Rostedt
2018-11-29 3:29 ` Steven Rostedt
2018-11-29 4:24 ` Steven Rostedt
2018-11-29 15:08 ` Joe Lawrence
2018-11-29 16:17 ` Steven Rostedt
2018-11-29 16:32 ` Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128203931.ym2rkya7a6agzzy3@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=jpoimboe@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).