From: Wei Yang <richard.weiyang@gmail.com>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: richard.weiyang@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] mm/alloc: fallback to first node if the wanted node offline
Date: Tue, 4 Dec 2018 08:34:28 +0000 [thread overview]
Message-ID: <20181204083428.emgcaomg6vulknaq@master> (raw)
In-Reply-To: <CAFgQCTvQBC11=4eGQ6T9vyB+KOznFCr4hjdg1wwD8GotSRWpDg@mail.gmail.com>
On Tue, Dec 04, 2018 at 03:20:13PM +0800, Pingfan Liu wrote:
>On Tue, Dec 4, 2018 at 2:54 PM Wei Yang <richard.weiyang@gmail.com> wrote:
>>
>> On Tue, Dec 04, 2018 at 11:05:57AM +0800, Pingfan Liu wrote:
>> >During my test on some AMD machine, with kexec -l nr_cpus=x option, the
>> >kernel failed to bootup, because some node's data struct can not be allocated,
>> >e.g, on x86, initialized by init_cpu_to_node()->init_memory_less_node(). But
>> >device->numa_node info is used as preferred_nid param for
>>
>> could we fix the preferred_nid before passed to
>> __alloc_pages_nodemask()?
>>
>Yes, we can doit too, but what is the gain?
node_zonelist() is used some places. If we are sure where the problem
is, it is not necessary to spread to other places.
>
>> BTW, I don't catch the function call flow to this point. Would you mind
>> giving me some hint?
>>
>You can track the code along slab_alloc() ->...->__alloc_pages_nodemask()
slab_alloc() pass NUMA_NO_NODE down, so I am lost in where the
preferred_nid is assigned.
>
>Thanks,
>Pingfan
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2018-12-04 8:34 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 3:05 [PATCH] mm/alloc: fallback to first node if the wanted node offline Pingfan Liu
2018-12-04 3:53 ` David Rientjes
2018-12-04 7:16 ` Pingfan Liu
2018-12-05 5:49 ` Pingfan Liu
2018-12-05 19:00 ` David Rientjes
2018-12-04 6:54 ` Wei Yang
2018-12-04 7:20 ` Pingfan Liu
2018-12-04 8:34 ` Wei Yang [this message]
2018-12-04 8:52 ` Pingfan Liu
2018-12-04 9:09 ` Wei Yang
2018-12-05 5:50 ` Pingfan Liu
2018-12-04 7:22 ` Michal Hocko
2018-12-04 8:20 ` Pingfan Liu
2018-12-04 8:40 ` Wei Yang
2018-12-04 8:56 ` Pingfan Liu
2018-12-04 8:56 ` Michal Hocko
2018-12-04 14:42 ` Vlastimil Babka
2018-12-05 5:38 ` Pingfan Liu
2018-12-05 9:21 ` Michal Hocko
2018-12-05 9:29 ` Pingfan Liu
2018-12-05 9:40 ` Vlastimil Babka
2018-12-06 3:07 ` Pingfan Liu
2018-12-06 8:28 ` Michal Hocko
2018-12-06 10:03 ` Pingfan Liu
2018-12-06 10:44 ` Pingfan Liu
2018-12-06 12:11 ` Michal Hocko
2018-12-07 2:56 ` Pingfan Liu
2018-12-07 7:53 ` Michal Hocko
2018-12-07 9:40 ` Pingfan Liu
2018-12-07 11:30 ` Michal Hocko
2018-12-07 13:20 ` Pingfan Liu
2018-12-07 14:22 ` Michal Hocko
2018-12-07 14:27 ` Pingfan Liu
2018-12-07 14:50 ` Michal Hocko
2018-12-07 15:56 ` Michal Hocko
2018-12-10 4:00 ` Pingfan Liu
2018-12-10 7:57 ` Pingfan Liu
2018-12-10 12:37 ` Michal Hocko
2018-12-11 8:05 ` Pingfan Liu
2018-12-11 9:44 ` Michal Hocko
2018-12-12 8:33 ` Pingfan Liu
2018-12-12 8:31 ` Pingfan Liu
2018-12-12 11:53 ` Michal Hocko
2018-12-13 8:37 ` Pingfan Liu
2018-12-13 9:04 ` Pingfan Liu
2018-12-17 13:29 ` Michal Hocko
2018-12-20 7:19 ` Pingfan Liu
2018-12-20 9:19 ` Michal Hocko
2019-01-08 14:34 ` Michal Hocko
2019-01-09 3:13 ` Pingfan Liu
2019-01-11 3:12 ` Pingfan Liu
2019-01-11 9:23 ` Michal Hocko
2018-12-17 12:57 ` Michal Hocko
2018-12-05 9:43 ` Michal Hocko
2018-12-06 3:34 ` Pingfan Liu
2018-12-06 7:23 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204083428.emgcaomg6vulknaq@master \
--to=richard.weiyang@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).