From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B8B5C04EBF for ; Wed, 5 Dec 2018 17:03:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2238520879 for ; Wed, 5 Dec 2018 17:03:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2238520879 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728402AbeLERDk (ORCPT ); Wed, 5 Dec 2018 12:03:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:33622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727388AbeLERDh (ORCPT ); Wed, 5 Dec 2018 12:03:37 -0500 Received: from vmware.local.home (unknown [208.91.3.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C94D12084C; Wed, 5 Dec 2018 17:03:36 +0000 (UTC) Date: Wed, 5 Dec 2018 12:03:34 -0500 From: Steven Rostedt To: Jiri Olsa Cc: Namhyung Kim , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Ingo Molnar , Andrew Morton , Tzvetomir Stoyanov , kernel-team@lge.com Subject: Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file Message-ID: <20181205120334.60d0478e@vmware.local.home> In-Reply-To: <20181205122517.GG2950@krava> References: <20181130154403.150474900@goodmis.org> <20181130154647.176265533@goodmis.org> <20181204074739.GC16733@sejong> <20181204144145.116a2caf@vmware.local.home> <20181205122517.GG2950@krava> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Dec 2018 13:25:17 +0100 Jiri Olsa wrote: > On Tue, Dec 04, 2018 at 02:41:45PM -0500, Steven Rostedt wrote: > > On Tue, 4 Dec 2018 16:47:39 +0900 > > Namhyung Kim wrote: > > > > > > > > @@ -302,6 +302,7 @@ install_headers: > > > > $(call QUIET_INSTALL, headers) \ > > > > $(call do_install,event-parse.h,$(prefix)/include/traceevent,644); \ > > > > $(call do_install,event-utils.h,$(prefix)/include/traceevent,644); \ > > > > + $(call do_install,trace-seq.h,$(prefix)/include/traceevent,644); \ > > > > $(call do_install,kbuffer.h,$(prefix)/include/traceevent,644) > > > > > > Do you still wanna have 'traceevent' directory prefix? I just > > > sometimes feel a bit annoying to type it. ;-) > > > > I'd still want the separate directory for it. I'll probably have a > > ftrace.h file added to this for ftrace specific code in the future. > > > > > > > > Or you can rename it something like 'tep' or 'libtep' - and hopefully > > > having only single header file to include.. > > > > > > > Hmm, I wonder if we should just call the directory "trace"? > > hum, I think it should match the library name, like 'include/tep/' I was hoping to add other headers in this directly, like ftrace.h and perf.h ;-) > > also we should change the plugin installation directory > > [jolsa@krava traceevent]$ rpm -ql perf | grep traceevent > /usr/lib64/traceevent > /usr/lib64/traceevent/plugins > /usr/lib64/traceevent/plugins/plugin_cfg80211.so > /usr/lib64/traceevent/plugins/plugin_function.so > /usr/lib64/traceevent/plugins/plugin_hrtimer.so > /usr/lib64/traceevent/plugins/plugin_jbd2.so > /usr/lib64/traceevent/plugins/plugin_kmem.so > /usr/lib64/traceevent/plugins/plugin_kvm.so > /usr/lib64/traceevent/plugins/plugin_mac80211.so > /usr/lib64/traceevent/plugins/plugin_sched_switch.so > /usr/lib64/traceevent/plugins/plugin_scsi.so > /usr/lib64/traceevent/plugins/plugin_xen.so Change it to tep? -- Steve