From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Milian Wolff <milian.wolff@kdab.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org, jolsa@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn
Date: Thu, 6 Dec 2018 18:29:20 -0300 [thread overview]
Message-ID: <20181206212920.GC32567@kernel.org> (raw)
In-Reply-To: <20181206205146.hsiehbf6fyee2uec@two.firstfloor.org>
Em Thu, Dec 06, 2018 at 12:51:48PM -0800, Andi Kleen escreveu:
> On Thu, Dec 06, 2018 at 02:01:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu:
> > > From: Andi Kleen <ak@linux.intel.com>
> > >
> > > This is a fix for another instance of the skid problem Milian
> > > recently found [1]
I think you forgot to add the reference, i.e. what is the url or
message-id that this [1] refers to?
> > Milian, have you tested this?
>
> It won't fix Milians problem, which were with call graphs.
>
> For Milian's issue you would need Milian's patches,
> which AFAIK haven't been reviewed by anyone.
/me trying to find these patches...
- Arnaldo
next prev parent reply other threads:[~2018-12-06 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 5:06 [PATCH] perf script: Fix LBR skid dump problems in brstackinsn Andi Kleen
2018-12-06 17:01 ` Arnaldo Carvalho de Melo
2018-12-06 20:51 ` Andi Kleen
2018-12-06 21:29 ` Arnaldo Carvalho de Melo [this message]
2018-12-06 22:52 ` Andi Kleen
2018-12-11 20:47 ` Milian Wolff
2018-12-07 9:21 ` Adrian Hunter
2019-01-03 13:13 ` [tip:perf/urgent] " tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206212920.GC32567@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milian.wolff@kdab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).