Hi Vivek, I love your patch! Perhaps something to improve: [auto build test WARNING on fuse/for-next] [also build test WARNING on v4.20-rc6] [cannot apply to next-20181210] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek-Goyal/virtio-fs-shared-file-system-for-virtual-machines/20181211-103034 base: https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next config: i386-randconfig-x000-201849 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): fs/fuse/file.c: In function 'fuse_dax_write_iter': fs/fuse/file.c:1834:47: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=] printk("fallocate(offset=0x%llx length=0x%lx)" ~~^ %x fs/fuse/file.c:1836:4: iov_iter_count(from), ret); ~~~~~~~~~~~~~~~~~~~~ fs/fuse/file.c:1834:11: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'ssize_t {aka int}' [-Wformat=] printk("fallocate(offset=0x%llx length=0x%lx)" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/fuse/file.c:1835:20: note: format string is defined here " failed. err=%ld\n", iocb->ki_pos, ~~^ %d In file included from include/linux/kernel.h:14:0, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from fs/fuse/fuse_i.h:13, from fs/fuse/file.c:9: include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:136:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:346:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ fs/fuse/file.c:1839:3: note: in expansion of macro 'pr_debug' pr_debug("fallocate(offset=0x%llx length=0x%lx)" ^~~~~~~~ fs/fuse/file.c:1839:48: note: format string is defined here pr_debug("fallocate(offset=0x%llx length=0x%lx)" ~~^ %x In file included from include/linux/kernel.h:14:0, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from fs/fuse/fuse_i.h:13, from fs/fuse/file.c:9: >> include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'ssize_t {aka int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:136:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:346:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ fs/fuse/file.c:1839:3: note: in expansion of macro 'pr_debug' pr_debug("fallocate(offset=0x%llx length=0x%lx)" ^~~~~~~~ fs/fuse/file.c:1840:20: note: format string is defined here " succeed. ret=%ld\n", iocb->ki_pos, iov_iter_count(from), ret); ~~^ %d -- fs//fuse/file.c: In function 'fuse_dax_write_iter': fs//fuse/file.c:1834:47: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=] printk("fallocate(offset=0x%llx length=0x%lx)" ~~^ %x fs//fuse/file.c:1836:4: iov_iter_count(from), ret); ~~~~~~~~~~~~~~~~~~~~ fs//fuse/file.c:1834:11: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'ssize_t {aka int}' [-Wformat=] printk("fallocate(offset=0x%llx length=0x%lx)" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs//fuse/file.c:1835:20: note: format string is defined here " failed. err=%ld\n", iocb->ki_pos, ~~^ %d In file included from include/linux/kernel.h:14:0, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from fs//fuse/fuse_i.h:13, from fs//fuse/file.c:9: include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:136:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:346:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ fs//fuse/file.c:1839:3: note: in expansion of macro 'pr_debug' pr_debug("fallocate(offset=0x%llx length=0x%lx)" ^~~~~~~~ fs//fuse/file.c:1839:48: note: format string is defined here pr_debug("fallocate(offset=0x%llx length=0x%lx)" ~~^ %x In file included from include/linux/kernel.h:14:0, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from fs//fuse/fuse_i.h:13, from fs//fuse/file.c:9: >> include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'ssize_t {aka int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:136:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:346:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ fs//fuse/file.c:1839:3: note: in expansion of macro 'pr_debug' pr_debug("fallocate(offset=0x%llx length=0x%lx)" ^~~~~~~~ fs//fuse/file.c:1840:20: note: format string is defined here " succeed. ret=%ld\n", iocb->ki_pos, iov_iter_count(from), ret); ~~^ %d vim +5 include/linux/kern_levels.h 314ba352 Joe Perches 2012-07-30 4 04d2c8c8 Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c8 Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c8 Joe Perches 2012-07-30 7 :::::: The code at line 5 was first introduced by commit :::::: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_ to a 2 byte pattern :::::: TO: Joe Perches :::::: CC: Linus Torvalds --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation