From: Rob Herring <robh@kernel.org>
To: Claudiu.Beznea@microchip.com
Cc: lgirdwood@gmail.com, broonie@kernel.org, mark.rutland@arm.com,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
Ludovic.Desroches@microchip.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/5] regulator: add documentation for regulator modes and suspend states
Date: Tue, 11 Dec 2018 16:13:24 -0600 [thread overview]
Message-ID: <20181211221324.GA14658@bogus> (raw)
In-Reply-To: <1543319801-19100-6-git-send-email-claudiu.beznea@microchip.com>
On Tue, Nov 27, 2018 at 11:57:25AM +0000, Claudiu.Beznea@microchip.com wrote:
> From: Claudiu Beznea <claudiu.beznea@microchip.com>
>
> Add documentation for regulator modes and suspend states.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> .../bindings/regulator/act8945a-regulator.txt | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/act8945a-regulator.txt b/Documentation/devicetree/bindings/regulator/act8945a-regulator.txt
> index ac955dea00d1..4017527619ab 100644
> --- a/Documentation/devicetree/bindings/regulator/act8945a-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/act8945a-regulator.txt
> @@ -15,11 +15,17 @@ Optional input supply properties:
> - inl67-supply: The input supply for REG_LDO3 and REG_LDO4
>
> Any standard regulator properties can be used to configure the single regulator.
> +regulator-initial-mode, regulator-allowed-modes and regulator-mode could be
> +specified using mode values from dt-bindings/regulator/active-semi,8945a-regulator.h
> +file.
>
> The valid names for regulators are:
> REG_DCDC1, REG_DCDC2, REG_DCDC3, REG_LDO1, REG_LDO2, REG_LDO3, REG_LDO4.
>
> Example:
> +
> +#include <dt-bindings/regulator/active-semi,8945a-regulator.h>
This file belongs in this patch.
> +
> pmic@5b {
> compatible = "active-semi,act8945a";
> reg = <0x5b>;
> @@ -32,6 +38,18 @@ Example:
> regulator-min-microvolt = <1350000>;
> regulator-max-microvolt = <1350000>;
> regulator-always-on;
> +
> + regulator-allowed-modes = <ACT8945A_REGULATOR_MODE_FIXED>,
> + <ACT8945A_REGULATOR_MODE_LOWPOWER>;
> + regulator-initial-mode = <ACT8945A_REGULATOR_MODE_FIXED>;
> +
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + regulator-suspend-min-microvolt=<1400000>;
> + regulator-suspend-max-microvolt=<1400000>;
> + regulator-changeable-in-suspend;
> + regulator-mode=<ACT8945A_REGULATOR_MODE_LOWPOWER>;
> + };
> };
>
> vdd_1v2_reg: REG_DCDC2 {
> @@ -39,6 +57,14 @@ Example:
> regulator-min-microvolt = <1100000>;
> regulator-max-microvolt = <1300000>;
> regulator-always-on;
> +
> + regulator-allowed-modes = <ACT8945A_REGULATOR_MODE_FIXED>,
> + <ACT8945A_REGULATOR_MODE_LOWPOWER>;
> + regulator-initial-mode = <ACT8945A_REGULATOR_MODE_FIXED>;
> +
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + };
> };
>
> vdd_3v3_reg: REG_DCDC3 {
> @@ -53,6 +79,14 @@ Example:
> regulator-min-microvolt = <2500000>;
> regulator-max-microvolt = <2500000>;
> regulator-always-on;
> +
> + regulator-allowed-modes = <ACT8945A_REGULATOR_MODE_NORMAL>,
> + <ACT8945A_REGULATOR_MODE_LOWPOWER>;
> + regulator-initial-mode = <ACT8945A_REGULATOR_MODE_NORMAL>;
> +
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + };
> };
>
> vdd_3v3_lp_reg: REG_LDO2 {
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-12-11 22:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 11:57 [PATCH v2 0/5] add PM functionality for act8945a PMIC Claudiu.Beznea
2018-11-27 11:57 ` [PATCH v2 1/5] regulator: act8945a-regulator: Implement PM functionalities Claudiu.Beznea
2018-11-27 11:57 ` [PATCH v2 2/5] regulator: act8945a-regulator: fix line over 80 chars warning Claudiu.Beznea
2018-11-27 11:57 ` [PATCH v2 3/5] regulator: act8945a-regulator: add shutdown function Claudiu.Beznea
2018-11-27 11:57 ` [PATCH v2 4/5] ARM: dts: at91: sama5d2_xplained: Add proper regulator states for suspend-to-mem Claudiu.Beznea
2018-11-27 11:57 ` [PATCH v2 5/5] regulator: add documentation for regulator modes and suspend states Claudiu.Beznea
2018-12-11 22:13 ` Rob Herring [this message]
2018-12-12 9:12 ` Claudiu.Beznea
2018-12-12 13:32 ` Rob Herring
2018-12-12 16:24 ` Claudiu.Beznea
2018-12-11 14:08 ` [PATCH v2 0/5] add PM functionality for act8945a PMIC Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211221324.GA14658@bogus \
--to=robh@kernel.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).