linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	"Herton R. Krzesinski" <herton@redhat.com>
Subject: Re: [PATCH 6/6] tools gpio: Override CFLAGS assignments
Date: Thu, 13 Dec 2018 12:23:44 +0100	[thread overview]
Message-ID: <20181213112344.GA9866@krava> (raw)
In-Reply-To: <20181212131501.GR10650@smile.fi.intel.com>

On Wed, Dec 12, 2018 at 03:15:01PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 12, 2018 at 11:25:37AM +0100, Jiri Olsa wrote:
> > So user could specify outside CFLAGS values.
> 
> For all three where I'm in Cc list
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

thanks, I should have cc-ed you on all of them ;-)

any idea who could I ask to pull these in?

thanks,
jirka

> 
> > 
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Jonathan Cameron <jic23@kernel.org>
> > Cc: Hartmut Knaack <knaack.h@gmx.de>
> > Cc: Lars-Peter Clausen <lars@metafoo.de>
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  tools/gpio/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/gpio/Makefile b/tools/gpio/Makefile
> > index 240eda014b37..6ecdd1067826 100644
> > --- a/tools/gpio/Makefile
> > +++ b/tools/gpio/Makefile
> > @@ -12,7 +12,7 @@ endif
> >  # (this improves performance and avoids hard-to-debug behaviour);
> >  MAKEFLAGS += -r
> >  
> > -CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
> > +override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
> >  
> >  ALL_TARGETS := lsgpio gpio-hammer gpio-event-mon
> >  ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS))
> > -- 
> > 2.17.2
> > 
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

  reply	other threads:[~2018-12-13 11:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 10:25 [PATCHv2 0/6] tools: Various build flags fixes Jiri Olsa
2018-12-12 10:25 ` [PATCH 1/6] tools power x86_energy_perf_policy: Override CFLAGS assignments and add LDFLAGS to build command Jiri Olsa
2019-01-03 13:20   ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-12-12 10:25 ` [PATCH 2/6] tools thermal tmon: Override CFLAGS assignments Jiri Olsa
2019-01-03 13:20   ` [tip:perf/urgent] tools thermal tmon: Allow overriding " tip-bot for Jiri Olsa
2018-12-12 10:25 ` [PATCH 3/6] tools thermal tmon: Use -O3 instead of -O1 if available Jiri Olsa
2018-12-12 10:25 ` [PATCH 4/6] tools power turbostat: Override CFLAGS assignments and add LDFLAGS to build command Jiri Olsa
2019-01-03 13:21   ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-12-12 10:25 ` [PATCH 5/6] tools iio: Override CFLAGS assignments Jiri Olsa
2018-12-12 18:50   ` Jonathan Cameron
2018-12-13 11:24     ` Jiri Olsa
2018-12-12 10:25 ` [PATCH 6/6] tools gpio: " Jiri Olsa
2018-12-12 13:15   ` Andy Shevchenko
2018-12-13 11:23     ` Jiri Olsa [this message]
2019-01-03 13:21   ` [tip:perf/urgent] tools gpio: Allow overriding CFLAGS tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181213112344.GA9866@krava \
    --to=jolsa@redhat.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=herton@redhat.com \
    --cc=jic23@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).