From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm-owner@vger.kernel.org"
<linux-arm-msm-owner@vger.kernel.org>,
"skannan@codeaurora.org" <skannan@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>
Subject: RE: [PATCH v4] PM / devfreq: Restart previous governor if new governor fails to start
Date: Fri, 14 Dec 2018 10:45:27 +0900 [thread overview]
Message-ID: <20181214014527epcms1p6c783b4cd1602bbcbcb6e725f840db479@epcms1p6> (raw)
In-Reply-To: <20181212135313.30268-1-sibis@codeaurora.org>
> From: Saravana Kannan <skannan@codeaurora.org>
>
> If the new governor fails to start, switch back to old governor so that the
> devfreq state is not left in some weird limbo.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> Signed-off-by: Saravana Kannan <skannan@codeaurora.org>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Hello,
In overall, the idea and the implementation looks good.
However, I have a question:
What if the following line fails?
+ df->governor->event_handler(df, DEVFREQ_GOV_START,
+ NULL);
Don't we still need something to handle for such events?
Cheers,
MyungJoo
next prev parent reply other threads:[~2018-12-14 1:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 13:53 [PATCH v4] PM / devfreq: Restart previous governor if new governor fails to start Sibi Sankar
[not found] ` <CGME20181212135338epcas5p12f7a8cd1c7aab5d5c936cbc5c33eee07@epcms1p6>
2018-12-14 1:45 ` MyungJoo Ham [this message]
2019-02-19 5:12 ` Sibi Sankar
2019-03-04 8:21 ` Sibi Sankar
[not found] ` <CGME20181212135338epcas5p12f7a8cd1c7aab5d5c936cbc5c33eee07@epcms1p8>
2019-03-05 7:18 ` MyungJoo Ham
2019-03-06 17:44 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214014527epcms1p6c783b4cd1602bbcbcb6e725f840db479@epcms1p6 \
--to=myungjoo.ham@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sibis@codeaurora.org \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).