From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Rob Herring <robh@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Frank Rowand <frowand.list@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 3/3] of/property: Add of_fwnode_name()
Date: Mon, 17 Dec 2018 14:15:18 +0200 [thread overview]
Message-ID: <20181217121518.GB14121@kuha.fi.intel.com> (raw)
In-Reply-To: <CAL_JsqLn3dbt-8Hjoja5AJip7FxLoWLAh0Cuk1eqE3Z8RiaO1A@mail.gmail.com>
On Fri, Dec 14, 2018 at 11:46:02AM -0600, Rob Herring wrote:
> On Fri, Dec 14, 2018 at 3:36 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Tue, Dec 11, 2018 at 2:15 PM Heikki Krogerus
> > <heikki.krogerus@linux.intel.com> wrote:
> > >
> > > This implements get_name fwnode op for DT.
> > >
> > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >
> > Rob, any objections here?
>
> Yes, what I said in v5.
I did address your comment in v5? The helper no longer tries to read
"name" property if the callback fails.
> At one point this series had a user which was finding a matching node
> by name. Now there is no user, so I can't really say whether this API
> makes sense or not.
That is a fair point. I choose to not to convert
fwnode_get_named_child_node() to use this helper because it would mean
we would have to allocate the buffer there, and I don't know if it's
worth it.
Let's forget about this for now. I was planning to use this helper for
matching a requested remote-endpoint (graph) device, but I'm not sure
if the node name is usable there.
I'll resend these as part of a real user for the API, if I ever have
one.
thanks,
--
heikki
next prev parent reply other threads:[~2018-12-17 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 13:14 [PATCH v6 0/3] device property: Add fwnode_get_name() helper Heikki Krogerus
2018-12-11 13:14 ` [PATCH v6 1/3] device property: Introduce fwnode_get_name() Heikki Krogerus
2018-12-11 13:14 ` [PATCH v6 2/3] ACPI: property: Add acpi_fwnode_name() Heikki Krogerus
2018-12-11 13:14 ` [PATCH v6 3/3] of/property: Add of_fwnode_name() Heikki Krogerus
2018-12-14 9:36 ` Rafael J. Wysocki
2018-12-14 17:46 ` Rob Herring
2018-12-17 12:15 ` Heikki Krogerus [this message]
2018-12-11 13:59 ` [PATCH v6 0/3] device property: Add fwnode_get_name() helper Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217121518.GB14121@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).