From: Thierry Reding <thierry.reding@gmail.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Vikram Prakash <vikram.prakash@broadcom.com>,
Scott Branden <scott.branden@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <ray.jui@broadcom.com>
Subject: [PATCH v3 04/19] mailbox: bcm-flexrm: Use device-managed registration API
Date: Thu, 20 Dec 2018 18:19:47 +0100 [thread overview]
Message-ID: <20181220172002.9016-5-thierry.reding@gmail.com> (raw)
In-Reply-To: <20181220172002.9016-1-thierry.reding@gmail.com>
From: Thierry Reding <treding@nvidia.com>
Get rid of some boilerplate driver removal code by using the newly added
device-managed registration API.
Cc: Vikram Prakash <vikram.prakash@broadcom.com>
Cc: Scott Branden <scott.branden@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <ray.jui@broadcom.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/mailbox/bcm-flexrm-mailbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
index d7a8ed7d8097..d713271ebf7c 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1665,7 +1665,7 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
mbox->controller.chans[index].con_priv = &mbox->rings[index];
/* Register mailbox controller */
- ret = mbox_controller_register(&mbox->controller);
+ ret = devm_mbox_controller_register(dev, &mbox->controller);
if (ret)
goto fail_free_debugfs_root;
@@ -1691,8 +1691,6 @@ static int flexrm_mbox_remove(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct flexrm_mbox *mbox = platform_get_drvdata(pdev);
- mbox_controller_unregister(&mbox->controller);
-
debugfs_remove_recursive(mbox->root);
platform_msi_domain_free_irqs(dev);
--
2.19.1
next prev parent reply other threads:[~2018-12-20 17:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 17:19 [PATCH v3 00/19] mailbox: Device-managed registration Thierry Reding
2018-12-20 17:19 ` [PATCH v3 01/19] mailbox: Add device-managed registration functions Thierry Reding
2018-12-20 17:19 ` [PATCH v3 02/19] mailbox: arm-mhu: Use device-managed registration API Thierry Reding
2018-12-20 17:19 ` [PATCH v3 03/19] mailbox: bcm2835: " Thierry Reding
2018-12-20 17:19 ` Thierry Reding [this message]
2018-12-20 17:46 ` [PATCH v3 04/19] mailbox: bcm-flexrm: " Scott Branden
2018-12-20 17:19 ` [PATCH v3 05/19] mailbox: bcm-pdc: " Thierry Reding
2018-12-20 17:19 ` [PATCH v3 06/19] mailbox: hi3660: " Thierry Reding
2018-12-20 17:19 ` [PATCH v3 07/19] mailbox: hi6220: " Thierry Reding
2018-12-20 17:19 ` [PATCH v3 08/19] mailbox: imx: " Thierry Reding
2018-12-20 17:19 ` [PATCH v3 09/19] mailbox: altera: " Thierry Reding
2018-12-20 17:19 ` [PATCH v3 10/19] mailbox: sti: " Thierry Reding
2018-12-20 17:19 ` [PATCH v3 11/19] mailbox: xgene-slimpro: " Thierry Reding
2018-12-20 17:19 ` [PATCH v3 12/19] mailbox: mtk-cmdq: " Thierry Reding
2018-12-20 17:19 ` [PATCH v3 13/19] mailbox: mtk-cmdq: Remove needless devm_kfree() calls Thierry Reding
2018-12-20 17:19 ` [PATCH v3 14/19] mailbox: omap: Use device-managed registration API Thierry Reding
2018-12-20 17:19 ` [PATCH v3 15/19] mailbox: platform-mhu: " Thierry Reding
2018-12-20 17:19 ` [PATCH v3 16/19] mailbox: qcom-apcs: " Thierry Reding
2018-12-20 17:20 ` [PATCH v3 17/19] mailbox: rockchip: " Thierry Reding
2018-12-20 17:20 ` [PATCH v3 18/19] mailbox: stm32-ipcc: " Thierry Reding
2018-12-20 17:20 ` [PATCH v3 19/19] mailbox: ti-msgmgr: " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220172002.9016-5-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=vikram.prakash@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).