From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: andy.gross@linaro.org
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
daniel.thompson@linaro.org, amit.kucheria@linaro.org,
linus.walleij@linaro.org, koen.kooi@linaro.org,
nicolas.dechesne@linaro.org
Subject: Re: [PATCH v3 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels
Date: Fri, 21 Dec 2018 08:05:57 +0530 [thread overview]
Message-ID: <20181221023554.GB3233@Mani-XPS-13-9360> (raw)
In-Reply-To: <20181029094245.7886-8-manivannan.sadhasivam@linaro.org>
On Mon, Oct 29, 2018 at 03:12:45PM +0530, Manivannan Sadhasivam wrote:
> For all 96Boards, the following standard is used for onboard LEDs.
>
> green:user1 default-trigger: heartbeat
> green:user2 default-trigger: mmc0/disk-activity(onboard-storage)
> green:user3 default-trigger: mmc1 (SD-card)
> green:user4 default-trigger: none, panic-indicator
> yellow:wlan default-trigger: phy0tx
> blue:bt default-trigger: hci0-power
>
> So lets adopt the same for APQ8016 SBC (Dragonboard410c), which is
> one of the 96Boards CE platform.
>
Hello,
Any update on this patch?
Regards,
Mani
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> index 46feedf7c989..35f95154316b 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> @@ -300,28 +300,28 @@
> compatible = "gpio-leds";
>
> led@1 {
> - label = "apq8016-sbc:green:user1";
> + label = "green:user1";
> gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> default-state = "off";
> };
>
> led@2 {
> - label = "apq8016-sbc:green:user2";
> + label = "green:user2";
> gpios = <&msmgpio 120 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "mmc0";
> default-state = "off";
> };
>
> led@3 {
> - label = "apq8016-sbc:green:user3";
> + label = "green:user3";
> gpios = <&pm8916_gpios 1 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "mmc1";
> default-state = "off";
> };
>
> led@4 {
> - label = "apq8016-sbc:green:user4";
> + label = "green:user4";
> gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "none";
> panic-indicator;
> @@ -329,14 +329,14 @@
> };
>
> led@5 {
> - label = "apq8016-sbc:yellow:wlan";
> + label = "yellow:wlan";
> gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "phy0tx";
> default-state = "off";
> };
>
> led@6 {
> - label = "apq8016-sbc:blue:bt";
> + label = "blue:bt";
> gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "bluetooth-power";
> default-state = "off";
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-12-21 2:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 9:42 [PATCH v3 0/7] Standardize onboard LED support for 96Boards Manivannan Sadhasivam
2018-10-29 9:42 ` [PATCH v3 1/7] arm64: dts: rockchip: ficus: Add on-board LED support Manivannan Sadhasivam
2018-12-11 19:11 ` Heiko Stuebner
2018-10-29 9:42 ` [PATCH v3 2/7] arm64: dts: rockchip: rock960: " Manivannan Sadhasivam
2018-12-11 19:11 ` Heiko Stuebner
2018-10-29 9:42 ` [PATCH v3 3/7] arm64: dts: hisilicon: hikey: Standardize LED labels and triggers Manivannan Sadhasivam
2018-10-29 9:42 ` [PATCH v3 4/7] arm64: dts: hisilicon: hikey960: " Manivannan Sadhasivam
2018-10-29 9:42 ` [PATCH v3 5/7] arm64: dts: hisilicon: poplar: " Manivannan Sadhasivam
2018-10-29 9:42 ` [PATCH v3 6/7] arm64: dts: xilinx: ultra96: " Manivannan Sadhasivam
2018-12-21 2:37 ` Manivannan Sadhasivam
2018-12-21 6:50 ` Michal Simek
2019-01-24 16:49 ` Rob Herring
2019-01-29 13:17 ` Michal Simek
2018-10-29 9:42 ` [PATCH v3 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels Manivannan Sadhasivam
2018-12-21 2:35 ` Manivannan Sadhasivam [this message]
2019-02-05 19:00 ` Nicolas Dechesne
2019-02-05 19:24 ` Bjorn Andersson
2018-10-31 13:38 ` [PATCH v3 0/7] Standardize onboard LED support for 96Boards Linus Walleij
[not found] ` <CAHTX3dJTXtuA0i-ffPjoiWuxEcF_5JY55VJtWd9zxW4HxK1K3w@mail.gmail.com>
2018-10-31 21:17 ` Linus Walleij
2018-11-01 10:49 ` Heiko Stübner
2018-11-29 15:42 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221023554.GB3233@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=andy.gross@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=koen.kooi@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-soc@vger.kernel.org \
--cc=nicolas.dechesne@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).