From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Sibi Sankar <sibis@codeaurora.org>,
david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
andy.gross@linaro.org, akdwived@codeaurora.org,
clew@codeaurora.org, linux-kernel@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org, ohad@wizery.com,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom: Add firmware bindings for Q6V5
Date: Thu, 3 Jan 2019 16:01:45 -0800 [thread overview]
Message-ID: <20190104000145.GJ31596@builder> (raw)
In-Reply-To: <20190103235043.GA195759@google.com>
On Thu 03 Jan 15:50 PST 2019, Brian Norris wrote:
> On Thu, Jan 03, 2019 at 03:30:14PM -0800, Brian Norris wrote:
> > On Fri, Dec 28, 2018 at 10:18:18AM +0530, Sibi Sankar wrote:
> > > +- firmware-name:
> > > + Usage: optional
> > > + Value type: <string>
> > > + Definition: must list the relative firmware image path for the
> > > + Hexagon Core.
> >
> > Relative to what? I still think it's a terrible idea that your driver
> > looks for files at the top-level /lib/firmware/ directory, but now
> > you're leaking this into the device tree. This should at a bare minimum
> > be namespaced to something like the qcom/ sub-directory. But ideally,
> > the driver would automatically be deriving a further sub-directory of
> > qcom/ based on the chipset or something, and then the only thing you'd
> > describe here is some kind of variant string -- something akin to
> > ath10k's qcom,ath10k-calibration-variant (see
> > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt), which
> > doesn't require a full path-name or any hierarchy.
>
> Oh, I see Rob actually recommended this binding in v1, and it's (sort
> of) in use by a few other drivers. Is it really expected that we put
> arbitrary pathnames in device tree? None of the binding documentation
> seems very specific to me, and their implementations *do* allow
> arbitrary text. As it stands today, this is a great recipe for name
> collision -- e.g., how the driver today suggests "modem.XYZ" names; is
> Qualcomm really the only one out there making modems? :D
>
> So my natural instinct is to avoid this. But if that's what everybody
> wants...
>
I share your concern about this, but I came to suggest this as the
driver cares about platforms but the firmware is (often?)
device/product-specific.
E.g. we will serve the MTP and Pixel 3 with the qcom,sdm845-adsp-pas
compatible, but they are unlikely to run the same adsp firmware. This
allows the individual dtb to specify which firmware the driver should
use.
Regards,
Bjorn
next prev parent reply other threads:[~2019-01-04 0:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 4:48 [PATCH v2 0/2] Add firmware bindings for Q6V5 MSS/PAS Sibi Sankar
2018-12-28 4:48 ` [PATCH v2 1/2] dt-bindings: remoteproc: qcom: Add firmware bindings for Q6V5 Sibi Sankar
2018-12-28 22:17 ` Rob Herring
2019-01-03 23:30 ` Brian Norris
2019-01-03 23:50 ` Brian Norris
2019-01-04 0:01 ` Bjorn Andersson [this message]
2019-01-04 0:11 ` Brian Norris
2019-01-05 1:54 ` Brian Norris
2019-01-08 10:50 ` Sibi Sankar
2019-01-08 15:22 ` Rob Herring
2019-01-09 21:55 ` Brian Norris
2019-01-10 14:56 ` Rob Herring
2018-12-28 4:48 ` [PATCH v2 2/2] remoteproc: qcom: Add support for parsing fw dt bindings Sibi Sankar
2019-01-03 23:09 ` Bjorn Andersson
2019-01-03 23:44 ` Brian Norris
2019-01-08 10:32 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104000145.GJ31596@builder \
--to=bjorn.andersson@linaro.org \
--cc=akdwived@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=briannorris@chromium.org \
--cc=clew@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).