From: Johan Hovold <johan@kernel.org>
To: Loys Ollivier <lollivier@baylibre.com>
Cc: devicetree@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH 0/4] Add driver for globaltop GNSS receivers
Date: Fri, 4 Jan 2019 10:19:37 +0100 [thread overview]
Message-ID: <20190104091937.GA4737@localhost> (raw)
In-Reply-To: <86bm4x6830.fsf@baylibre.com>
On Thu, Jan 03, 2019 at 05:04:35PM +0100, Loys Ollivier wrote:
>
> As suggested by Neil Armstrong - this GNSS device seems to behave like
> most generic GNSS receivers.
> I'll send a v2 with a generic driver that works for both GlobalTop and
> u-blox.
That doesn't sound right to me. Judging from a quick look, this device
appears to be based on a mediatek chipset, so I suggest reworking
(renaming) this as a Mediatek driver (gnss type would be MTK, reflecting
the vendor protocol) even if it happens to look a lot like the current
u-blox driver.
If we ever add more features, like support for some part of the vendor
protocol or maybe 1pps, things will start diverging. As you noticed you
already have the generic serial gnss implementation to handle a lot of
the common bits.
> Loys Ollivier writes:
>
> > Hello !
> >
> > This patch series adds a new GNSS driver for the globaltop GNSS
> > receivers. These receivers transmits NMEA output sequence as soon
> > as they have booted. Power management can be done via the main
> > supply and optional backup supply as defined in the device tree.
> >
> > The driver has been tested using a GlobalTop pa6h chipset on a
> > Libretech-cc board using the expansion header. Changes made in the
> > board device tree can be found below for reference and testing.
Thanks,
Johan
next prev parent reply other threads:[~2019-01-04 9:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 10:50 [PATCH 0/4] Add driver for globaltop GNSS receivers Loys Ollivier
2018-12-28 10:50 ` [PATCH 1/4] dt-bindings: Add vendor prefix for "GlobalTop Technology, Inc." Loys Ollivier
2019-01-11 14:40 ` Rob Herring
2018-12-28 10:50 ` [PATCH 2/4] dt-bindings: gnss: add gtop binding Loys Ollivier
2019-01-11 14:43 ` Rob Herring
2018-12-28 10:50 ` [PATCH 3/4] gnss: add gtop receiver type support Loys Ollivier
2018-12-28 10:50 ` [PATCH 4/4] gnss: add driver for globaltop receivers Loys Ollivier
2019-01-03 16:04 ` [PATCH 0/4] Add driver for globaltop GNSS receivers Loys Ollivier
2019-01-04 9:19 ` Johan Hovold [this message]
2019-01-07 16:21 ` Loys Ollivier
2019-01-07 16:37 ` Johan Hovold
2019-01-04 17:51 ` Rob Herring
2019-01-15 10:00 ` Loys Ollivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104091937.GA4737@localhost \
--to=johan@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lollivier@baylibre.com \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).