From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: andy.gross@linaro.org, robh@kernel.org, sboyd@kernel.org,
ulf.hansson@linaro.org, collinsd@codeaurora.org,
mka@chromium.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
henryc.chen@mediatek.com
Subject: Re: [PATCH v10 1/9] dt-bindings: opp: Introduce opp-level bindings
Date: Wed, 9 Jan 2019 14:39:12 +0530 [thread overview]
Message-ID: <20190109090912.ciq4uzo5sjghyms2@vireshk-i7> (raw)
In-Reply-To: <20190109090420.8100-2-rnayak@codeaurora.org>
On 09-01-19, 14:34, Rajendra Nayak wrote:
> On some SoCs (especially from Qualcomm and MediaTek) an OPP
> node needs to describe an additional level/corner value
> that is then communicated to a remote microprocessor by the CPU, which
> then takes some actions (like adjusting voltage values across variousi
> rails) based on the value passed.
>
> Add opp-level as an additional property in the OPP node and describe it
> in the OPP bindings document.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
> Documentation/devicetree/bindings/opp/opp.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
> index c396c4c0af92..e83fb7cbfd58 100644
> --- a/Documentation/devicetree/bindings/opp/opp.txt
> +++ b/Documentation/devicetree/bindings/opp/opp.txt
> @@ -129,6 +129,11 @@ Optional properties:
> - opp-microamp-<name>: Named opp-microamp property. Similar to
> opp-microvolt-<name> property, but for microamp instead.
>
> +- opp-level: On some SoC platforms an OPP node can describe a positive value
> + representing a corner/level that's communicated with a remote microprocessor
> + (usually called the power manager) which then translates it into a certain
> + voltage on a voltage rail.
> +
This binding is generic enough and doesn't have anything to do with a
remote mp and so such statements should be avoided in here. And then
Linux can use it the way it wants.
Maybe just say that it describes the performance level of the device.
That's all.
> - clock-latency-ns: Specifies the maximum possible transition latency (in
> nanoseconds) for switching to this OPP from any other OPP.
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
--
viresh
next prev parent reply other threads:[~2019-01-09 9:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 9:04 [PATCH v10 0/9] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2019-01-09 9:04 ` [PATCH v10 1/9] dt-bindings: opp: Introduce opp-level bindings Rajendra Nayak
2019-01-09 9:09 ` Viresh Kumar [this message]
2019-01-09 9:20 ` Rajendra Nayak
2019-01-09 9:24 ` Viresh Kumar
2019-01-09 9:04 ` [PATCH v10 2/9] OPP: Add support for parsing the 'opp-level' property Rajendra Nayak
2019-01-09 9:12 ` Viresh Kumar
2019-01-09 9:23 ` Rajendra Nayak
2019-01-09 9:04 ` [PATCH v10 3/9] dt-bindings: power: Add qcom rpm power domain driver bindings Rajendra Nayak
2019-01-09 9:04 ` [PATCH v10 4/9] soc: qcom: rpmpd: Add a Power domain driver to model corners Rajendra Nayak
2019-01-09 9:04 ` [PATCH v10 5/9] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2019-01-09 9:04 ` [PATCH v10 6/9] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2019-01-09 9:04 ` [PATCH v10 7/9] soc: qcom: rpmhpd: Add RPMh power domain driver Rajendra Nayak
2019-01-09 9:04 ` [PATCH v10 8/9] arm64: dts: sdm845: Add rpmh powercontroller node Rajendra Nayak
2019-01-09 9:04 ` [PATCH v10 9/9] soc: qcom: rpmhpd: Mark mx as a parent for cx Rajendra Nayak
2019-01-10 3:58 [PATCH v10 0/9] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2019-01-10 3:58 ` [PATCH v10 1/9] dt-bindings: opp: Introduce opp-level bindings Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109090912.ciq4uzo5sjghyms2@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andy.gross@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=henryc.chen@mediatek.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).