From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D681DC43387 for ; Fri, 11 Jan 2019 14:30:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7D192133F for ; Fri, 11 Jan 2019 14:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547217026; bh=1F1Aeh6m4aVCtDHdroK7VgvU6c1gK5PaFePVcnQ1SOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bdkMcnx7hXei4Xe8dmuE4jbiEnwFdy7T1sz3z+bpu15f7PFaNqaVoiHu2vuopnG/8 /EGj1ItUxKR/4JPn1jf7SklOXSeqnNWQHWZsQ3LUHn0TxP4452lG9BF8CHt5OfmwI9 41MZ6srZ2GCQ6mUoHmAeE9mp/mtCWAOzuHqbF3F4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388954AbfAKOaZ (ORCPT ); Fri, 11 Jan 2019 09:30:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:49640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388925AbfAKOaV (ORCPT ); Fri, 11 Jan 2019 09:30:21 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF72E2063F; Fri, 11 Jan 2019 14:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547217021; bh=1F1Aeh6m4aVCtDHdroK7VgvU6c1gK5PaFePVcnQ1SOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pl4jlpQmnZphz7ljNzay6OUhjmgupyR1vg+86uG8jY6zfas8bcxXxQVx+2Z+a2Xvx fvhZgwBnw/pm2uboIOqBOjGdPwTkFn3C0naEyBLoguhUcvvSDGZNPspe/QYQWDGLAk vfjdi8vzTomzN1lqEAO9mYDwduRYnV/ZPiRgS7jY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 013/105] scsi: bnx2fc: Fix NULL dereference in error handling Date: Fri, 11 Jan 2019 15:13:44 +0100 Message-Id: <20190111131104.260850998@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190111131102.899065735@linuxfoundation.org> References: <20190111131102.899065735@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 9ae4f8420ed7be4b13c96600e3568c144d101a23 ] If "interface" is NULL then we can't release it and trying to will only lead to an Oops. Fixes: aea71a024914 ("[SCSI] bnx2fc: Introduce interface structure for each vlan interface") Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index 6844ba361616..89f09b122135 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c @@ -2372,7 +2372,7 @@ static int _bnx2fc_create(struct net_device *netdev, if (!interface) { printk(KERN_ERR PFX "bnx2fc_interface_create failed\n"); rc = -ENOMEM; - goto ifput_err; + goto netdev_err; } if (is_vlan_dev(netdev)) { -- 2.19.1