From: Nathan Chancellor <natechancellor@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"Manoj N. Kumar" <manoj@linux.ibm.com>,
"Matthew R. Ochs" <mrochs@linux.ibm.com>,
Uma Krishnan <ukrishn@linux.ibm.com>,
Bradley Grove <linuxdrivers@attotech.com>,
Don Brace <don.brace@microsemi.com>,
Brian King <brking@us.ibm.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, esc.storagedev@microsemi.com,
Nick Desaulniers <ndesaulniers@google.com>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH v3] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template
Date: Sun, 13 Jan 2019 21:57:54 -0700 [thread overview]
Message-ID: <20190114045754.GA8440@flashbox> (raw)
In-Reply-To: <c1f7f039-04b2-a660-2408-8d4ac0ea63c4@acm.org>
On Sun, Jan 13, 2019 at 08:54:35PM -0800, Bart Van Assche wrote:
> On 1/13/19 8:42 PM, Nathan Chancellor wrote:
> > @@ -1292,7 +1292,7 @@ int esas2r_ioctl_handler(void *hostdata, int cmd, void __user *arg)
> > ioctl = memdup_user(arg, sizeof(struct atto_express_ioctl));
> > if (IS_ERR(ioctl)) {
> > esas2r_log(ESAS2R_LOG_WARN,
> > - "ioctl_handler access_ok failed for cmd %d, "
> > + "ioctl_handler access_ok failed for cmd %u, "
> > "address %p", cmd,
> > arg);
> > return PTR_ERR(ioctl);
>
> If you have to repost this patch, please use that opportunity to join the
> above split strings. Additionally, since this patch touches much more SCSI
Sorry, I should have caught that. If I have to post again, I will fix
that.
> code than ATA code I think it should have been sent to Martin instead of to
> Jens. Anyway:
>
I had Jens, Martin, and James on the 'to' line, with all of the other
maintainers of the individual files on cc. If I should have done it
differently, please let me know.
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>
Thank you, I will carry this forward if I need to.
Nathan
next prev parent reply other threads:[~2019-01-14 4:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 17:57 [PATCH] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template Nathan Chancellor
2018-10-19 19:38 ` Bart Van Assche
2018-10-20 4:52 ` kbuild test robot
2018-10-20 5:01 ` [PATCH v2] " Nathan Chancellor
2018-12-17 17:31 ` Nathan Chancellor
2019-01-14 4:42 ` [PATCH v3] " Nathan Chancellor
2019-01-14 4:54 ` Bart Van Assche
2019-01-14 4:57 ` Nathan Chancellor [this message]
2019-01-26 7:52 ` [PATCH v4] " Nathan Chancellor
2019-01-26 9:19 ` Nick Desaulniers
2019-01-28 16:16 ` Don.Brace
2019-01-28 16:17 ` Nathan Chancellor
2019-02-05 18:42 ` Grove, Bradley
2019-02-07 10:52 ` Marc Gonzalez
2019-02-07 16:07 ` [PATCH v5] " Nathan Chancellor
2019-02-07 19:17 ` Nick Desaulniers
2019-02-08 8:05 ` Christoph Hellwig
2019-02-08 16:00 ` Nathan Chancellor
2019-02-08 22:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114045754.GA8440@flashbox \
--to=natechancellor@gmail.com \
--cc=aacraid@microsemi.com \
--cc=axboe@kernel.dk \
--cc=brking@us.ibm.com \
--cc=bvanassche@acm.org \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxdrivers@attotech.com \
--cc=manoj@linux.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mrochs@linux.ibm.com \
--cc=ndesaulniers@google.com \
--cc=ukrishn@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).