From: Joerg Roedel <joro@8bytes.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, jfehlig@suse.com,
jon.grimm@amd.com, brijesh.singh@amd.com, jroedel@suse.de
Subject: Re: [PATCH 2/3] dma: Introduce dma_max_mapping_size()
Date: Tue, 15 Jan 2019 17:23:22 +0100 [thread overview]
Message-ID: <20190115162322.GA4681@8bytes.org> (raw)
In-Reply-To: <20190115133754.GB29225@lst.de>
On Tue, Jan 15, 2019 at 02:37:54PM +0100, Christoph Hellwig wrote:
> > +size_t dma_direct_max_mapping_size(struct device *dev)
> > +{
> > + /*
> > + * Return the minimum of the direct DMA limit and the SWIOTLB limit.
> > + * Since direct DMA has no limit, it is fine to just return the SWIOTLB
> > + * limit.
> > + */
> > + return swiotlb_max_mapping_size(dev);
>
> Well, if we don't actually use the swiotlb buffers despite it being
> compiled in or even allocated we don't need the limit.
Right, I thought about that too, but didn't find a generic way to check
for all the cases. There are various checks that could be done:
1) Check if SWIOTLB is initialized at all, if not, return
SIZE_MAX as the limit. This can't be checked from dma-direct
code right now, but could be easily implemented.
2) Check for swiotlb=force needs to be done.
3) Check whether the device can access all of available RAM. I
have no idea how to check that in an architecture independent
way. It also has to take memory hotplug into account as well
as the DMA mask of the device.
An easy approximation could be to omit the limit if the
dma-mask covers all of the physical address bits available
on the platform. It would require to pass the dma-mask as an
additional parameter like it is done in dma_supported().
Any better ideas for how to implement 3)?
Regards,
Joerg
next prev parent reply other threads:[~2019-01-15 16:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 13:22 [PATCH 0/3 v2] Fix virtio-blk issue with SWIOTLB Joerg Roedel
2019-01-15 13:22 ` [PATCH 1/3] swiotlb: Introduce swiotlb_max_mapping_size() Joerg Roedel
2019-01-15 13:22 ` [PATCH 2/3] dma: Introduce dma_max_mapping_size() Joerg Roedel
2019-01-15 13:37 ` Christoph Hellwig
2019-01-15 16:23 ` Joerg Roedel [this message]
2019-01-15 17:54 ` Christoph Hellwig
2019-01-15 13:22 ` [PATCH 3/3] virtio-blk: Consider dma_max_mapping_size() for maximum segment size Joerg Roedel
2019-01-16 14:05 ` Michael S. Tsirkin
2019-01-16 14:10 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115162322.GA4681@8bytes.org \
--to=joro@8bytes.org \
--cc=axboe@kernel.dk \
--cc=brijesh.singh@amd.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=jfehlig@suse.com \
--cc=jon.grimm@amd.com \
--cc=jroedel@suse.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).