From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Balakrishna Godavarthi <bgodavar@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-mtp: Add WCN3990 BT node
Date: Thu, 17 Jan 2019 13:55:59 -0800 [thread overview]
Message-ID: <20190117215559.GC12955@builder> (raw)
In-Reply-To: <20190117192812.GV261387@google.com>
On Thu 17 Jan 11:28 PST 2019, Matthias Kaehlcke wrote:
> On Wed, Jan 16, 2019 at 08:40:06PM -0800, Bjorn Andersson wrote:
[..]
> > +&qup_uart6_default {
> > + pinmux {
> > + pins = "gpio45", "gpio46", "gpio47", "gpio48";
> > + function = "qup6";
> > + };
> > +
> > + ctsrx {
> > + pins = "gpio45", "gpio48";
> > + drive-strength = <2>;
>
> CTS and RX are input signals, no need to configure drive strength in
> this case IIUC.
>
Right, didn't think that far when I hacked this up.
> > + bias-no-pull;
>
> On another SDM845 based device we observe garbage on RX at
> initialization time, unless we enable a pull-up.
>
> > + };
> > +
> > + rts {
> > + pins = "gpio46";
> > + drive-strength = <2>;
> > + bias-pull-down;
> > + };
>
> On our device we don't configure a pull on the lines driven by the
> AP. I think a pull-down on RTS should be fine though since it matches
> the pull (during reset) on CTS of the BT module.
>
> > + tx {
> > + pins = "gpio47";
> > + drive-strength = <2>;
> > + bias-pull-up;
> > + };
> > +};
>
> Similar to RTS, the pull matches the one on RXD of the BT module.
>
> For reference, this is what we currently use on our device:
>
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1391888/3/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
>
Thanks, I will update the patch.
Regards,
Bjorn
prev parent reply other threads:[~2019-01-17 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 4:40 [PATCH] arm64: dts: qcom: sdm845-mtp: Add WCN3990 BT node Bjorn Andersson
2019-01-17 6:10 ` Balakrishna Godavarthi
2019-01-17 21:53 ` Bjorn Andersson
2019-01-17 19:28 ` Matthias Kaehlcke
2019-01-17 21:55 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117215559.GC12955@builder \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bgodavar@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).