From: Johan Hovold <johan@kernel.org>
To: Loys Ollivier <lollivier@baylibre.com>
Cc: devicetree@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH v2 3/4] gnss: add mtk receiver type support
Date: Fri, 25 Jan 2019 10:12:56 +0100 [thread overview]
Message-ID: <20190125091256.GC3691@localhost> (raw)
In-Reply-To: <1547744074-28308-4-git-send-email-lollivier@baylibre.com>
On Thu, Jan 17, 2019 at 05:54:33PM +0100, Loys Ollivier wrote:
> Add an MTK (Mediatek) type to the "GNSS_TYPE" attribute.
>
> Note that MTK receivers support a subset of NMEA 0183 with vendor
> extensions (e.g. to allow switching to the vendor protocol).
Copy paste error? AFAICT there is no Mediatek vendor protocol, only the
extensions to NMEA.
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
> ---
>
> v2: renamed from GTOP to MTK.
>
> include/linux/gnss.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/gnss.h b/include/linux/gnss.h
> index 43546977098c..36968a0f33e8 100644
> --- a/include/linux/gnss.h
> +++ b/include/linux/gnss.h
> @@ -22,6 +22,7 @@ enum gnss_type {
> GNSS_TYPE_NMEA = 0,
> GNSS_TYPE_SIRF,
> GNSS_TYPE_UBX,
> + GNSS_TYPE_MTK,
>
> GNSS_TYPE_COUNT
> };
Add the gnss_type_names string in this patch along with the define.
Johan
next prev parent reply other threads:[~2019-01-25 9:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 16:54 [PATCH v2 0/4] Add driver for Mediatek-based GNSS receivers Loys Ollivier
2019-01-17 16:54 ` [PATCH v2 1/4] dt-bindings: Add vendor prefix for "GlobalTop Technology, Inc." Loys Ollivier
2019-01-21 17:09 ` Rob Herring
2019-01-17 16:54 ` [PATCH v2 2/4] dt-bindings: gnss: add mediatek binding Loys Ollivier
2019-01-21 17:10 ` Rob Herring
2019-01-21 17:27 ` Loys Ollivier
2019-01-21 18:44 ` Sean Wang
2019-01-22 8:47 ` Loys Ollivier
2019-01-22 10:25 ` Sean Wang
2019-01-21 21:51 ` Rob Herring
2019-01-22 8:49 ` Loys Ollivier
2019-01-25 9:07 ` Johan Hovold
2019-01-28 15:46 ` Loys Ollivier
2019-02-11 8:33 ` Johan Hovold
2019-02-11 14:17 ` Loys Ollivier
2019-02-13 15:22 ` Loys Ollivier
2019-02-13 15:24 ` Loys Ollivier
2019-02-14 9:11 ` Johan Hovold
2019-02-15 12:10 ` Loys Ollivier
2019-02-15 16:00 ` Johan Hovold
2019-01-17 16:54 ` [PATCH v2 3/4] gnss: add mtk receiver type support Loys Ollivier
2019-01-25 9:12 ` Johan Hovold [this message]
2019-01-17 16:54 ` [PATCH v2 4/4] gnss: add driver for mediatek receivers Loys Ollivier
2019-01-25 9:30 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125091256.GC3691@localhost \
--to=johan@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lollivier@baylibre.com \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).