From: Ingo Molnar <mingo@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: kjlu@umn.edu, hpa@zytor.com, stable@vger.kernel.org,
peterz@infradead.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched/core: Fix a potential double-fetch bug in sched_copy_attr()
Date: Sun, 27 Jan 2019 12:28:22 +0100 [thread overview]
Message-ID: <20190127112822.GA34170@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1901271201170.1622@nanos.tec.linutronix.de>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> On Mon, 21 Jan 2019, tip-bot for Kangjie Lu wrote:
> > Commit-ID: 120e4e76857ddbc9268e1aa3f9de61a498e84618
> > Gitweb: https://git.kernel.org/tip/120e4e76857ddbc9268e1aa3f9de61a498e84618
> > Author: Kangjie Lu <kjlu@umn.edu>
> > AuthorDate: Wed, 9 Jan 2019 01:45:24 -0600
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Mon, 21 Jan 2019 11:26:17 +0100
> >
> > sched/core: Fix a potential double-fetch bug in sched_copy_attr()
> >
> > "uattr->size" is copied in from user space and checked. However, it is
> > copied in again after the security check. A malicious user may race to
> > change it. The fix sets uattr->size to be the checked size.
> >
> > Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: pakki001@umn.edu
> > Cc: <stable@vger.kernel.org>
> > Link: https://lkml.kernel.org/r/20190109074524.10176-1-kjlu@umn.edu
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > ---
> > kernel/sched/core.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index a674c7db2f29..d4d3514c4fe9 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -4499,6 +4499,9 @@ static int sched_copy_attr(struct sched_attr __user *uattr, struct sched_attr *a
> > if (ret)
> > return -EFAULT;
> >
> > + /* In case attr->size was changed by user-space: */
> > + attr->size = size;
> > +
>
> Just when pondering to send that to Linus, I tried to write up a concise
> summary for this which made me look at the patch.
>
> If the size changed, then its clear that user space fiddled with the date
> between the size fetch and the full copy from user. So why restoring the
> size instead of doing the obvious:
>
> if (attr->size != size)
> return -ECRAP;
>
> Hmm?
Yeah, indeed - and that's a much more reliable interface behavior in any
case. It's probably also faster.
Thanks,
Ingo
next prev parent reply other threads:[~2019-01-27 11:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-25 22:16 [PATCH] sched: fix a potential double-fetch bug in sched_copy_attr Kangjie Lu
2019-01-07 17:11 ` Peter Zijlstra
2019-01-09 7:45 ` [PATCH v2] " Kangjie Lu
2019-01-21 11:32 ` [tip:sched/core] sched/core: Fix a potential double-fetch bug in sched_copy_attr() tip-bot for Kangjie Lu
2019-01-27 11:04 ` Thomas Gleixner
2019-01-27 11:28 ` Ingo Molnar [this message]
2019-01-28 7:58 ` Peter Zijlstra
2019-01-28 13:15 ` Thomas Gleixner
2019-03-10 10:09 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127112822.GA34170@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).