From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, peterz@infradead.org,
vincent.guittot@linaro.org, morten.rasmussen@arm.com,
Dietmar.Eggemann@arm.com
Subject: [PATCH v2 0/3] sched/fair: NOHZ cleanups and misfit improvement
Date: Mon, 11 Feb 2019 17:59:43 +0000 [thread overview]
Message-ID: <20190211175946.4961-1-valentin.schneider@arm.com> (raw)
In
commit 5fbdfae5221a ("sched/fair: Kick nohz balance if rq->misfit_task_load")
was added a trigger for nohz kicks, which is required to offload misfit tasks
from LITTLE to big CPUs. However, those kicks could be issued a lot more
frequently than what is strictly needed.
This patch-set tunes down unneeded nohz kicks.
- Patch 1 adds some more comments to nohz_balancer_kick()
- Patches [2-3] tweak the nohz kick conditions for asymmetric systems
* Changes since v1
- Patches 1-3 from v1 are in tip/sched/core and thus not included
tip HEAD is 1b5500d73466 ("sched/fair: Remove unused 'sd' parameter from select_idle_smt()")
- Patch 1 from v2 is new (Peter)
- Patch 3 from v2 (5 from v1) now shuffles conditions to avoid a goto (Peter)
* nohz_balancer_kick() shuffling impact
The ASYM_PACKING loop used to be towards the end of nohz_balancer_kick(),
and the LLC condition was higher up. Since the LLC condition is very
often true, we probably were avoiding the loop most of the time on systems
that use ASYM_PACKING. However, I don't have one at hand and I'm not sure
hacking up a kernel to enable ASYM_PACKING on a system that doesn't need it
would be truly relevant.
I ran 20 iterations of
'hackbench -g 1 -l 100000'
on a 2-sockets Xeon E5 (40 logical cores, no ASYM_PACKING) but the difference
(hackbench duration & nohz_balancer_kick() FTrace profiling) lies in the noise.
--------------------------------------------------------------------------------
* Testing
** kick_ilb() hits
This causes a large reduction in calls to kick_ilb() (and thus subsequent
rescheduling interrupts & useless nohz balance calls) in most scenarios.
The "best case" one is running NR_BIG_CPUS big tasks, which I tested with
4 50% periodic tasks running for 5 seconds on my HiKey960 (4x4 big.LITTLE):
| CPU | hits (baseline) | hits (patchset) |
|-----+-----------------+-----------------|
| 0 | 31 | 41 |
| 1 | 21 | 3 |
| 2 | 35 | 2 |
| 3 | 9 | 4 |
|-----+-----------------+-----------------|
| 4 | 170 | 4 |
| 5 | 573 | 4 |
| 6 | 544 | 4 |
| 7 | 579 | 4 |
Something a bit less idealistic with NR_CPUS-1 big tasks still shows some
improvements (7 100% tasks running for 5 seconds on my HiKey960):
| CPU | hits (baseline) | hits (patchset) |
|-----+-----------------+-----------------|
| 0 | 14 | 122 |
| 1 | 47 | 162 |
| 2 | 11 | 156 |
| 3 | 9 | 3 |
|-----+-----------------+-----------------|
| 4 | 53 | 6 |
| 5 | 276 | 13 |
| 6 | 312 | 7 |
| 7 | 250 | 11 |
I was surprised to see such an increase in calls to kick_ilb() from LITTLE
CPUs ([0-3]), but after a bit of investigation it turns out that the big
CPUs would always run nohz_balancer_kick() a jiffy before the LITTLEs, so
the LITTLEs would always bail out because nohz.next_balance had just been
updated before they called nohz_balancer_kick(). IOW,
time_before(now, nohz.next_balance)
would always be true on CPUs [0-3] during my workload. Quieting the kicks
issued by the big CPUs allowed the LITTLEs to execute nohz_balancer_kick()
past that condition, explaining the higher number of kicks issued from LITTLE
CPUs.
** misfit behaviour
For good measure I also ran the usual misfit tests [1] which showed no
particular change.
[1]: https://github.com/ARM-software/lisa/blob/next/lisa/tests/kernel/scheduler/misfit.py
Valentin Schneider (3):
sched/fair: Comment some nohz_balancer_kick() kick conditions
sched/fair: Tune down misfit nohz kicks
sched/fair: Skip LLC nohz logic for asymmetric systems
kernel/sched/fair.c | 84 +++++++++++++++++++++++++++++++++------------
1 file changed, 63 insertions(+), 21 deletions(-)
--
2.20.1
next reply other threads:[~2019-02-11 18:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 17:59 Valentin Schneider [this message]
2019-02-11 17:59 ` [PATCH v2 1/3] sched/fair: Comment some nohz_balancer_kick() kick conditions Valentin Schneider
2019-03-09 14:36 ` [tip:sched/urgent] " tip-bot for Valentin Schneider
2019-03-19 11:12 ` tip-bot for Valentin Schneider
2019-02-11 17:59 ` [PATCH v2 2/3] sched/fair: Tune down misfit nohz kicks Valentin Schneider
2019-03-09 14:37 ` [tip:sched/urgent] sched/fair: Tune down misfit NOHZ kicks tip-bot for Valentin Schneider
2019-03-19 11:13 ` tip-bot for Valentin Schneider
2019-02-11 17:59 ` [PATCH v2 3/3] sched/fair: Skip LLC nohz logic for asymmetric systems Valentin Schneider
2019-03-09 14:38 ` [tip:sched/urgent] sched/fair: Skip LLC NOHZ " tip-bot for Valentin Schneider
2019-03-19 11:13 ` tip-bot for Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211175946.4961-1-valentin.schneider@arm.com \
--to=valentin.schneider@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).