From: Masami Hiramatsu <mhiramat@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Changbin Du <changbin.du@gmail.com>, Jann Horn <jannh@google.com>,
Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@kernel.org>, Nadav Amit <namit@vmware.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3 0/5] tracing/probes: uaccess: Add support user-space access
Date: Thu, 28 Feb 2019 10:54:31 +0900 [thread overview]
Message-ID: <20190228105431.ca1fbf6ae6fca15de2f17c22@kernel.org> (raw)
In-Reply-To: <20190227223239.x42tnefzwpbpkq3t@ast-mbp>
On Wed, 27 Feb 2019 14:32:41 -0800
Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> On Wed, Feb 27, 2019 at 11:42:15PM +0900, Masami Hiramatsu wrote:
> >
> > For perf-probe, we can add some attribute for each argument
> > which indicate that the variable in user space. But still
> > we can not decide it automatically by DWARF since __user attribute
> > is not transrated to DWARF attribute.
>
> clang has partial support for __attribute__((noderef, address_space(1)))
> We'll work on patches to make it complete and pass __user attribute
> all the way to debug info.
Great! That's what I need. Could you point where (or who) I should check the
implementation?
I guess it will add DW_AT_segment to variable instance, if so it is easy
to support it in perf probe.
>
> If somebody can work with gcc folks to do the same that would be awesome.
>
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2019-02-28 1:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 14:42 [PATCH v3 0/5] tracing/probes: uaccess: Add support user-space access Masami Hiramatsu
2019-02-27 14:42 ` [PATCH v3 1/5] uaccess: Add user_access_ok() Masami Hiramatsu
2019-02-27 14:43 ` [PATCH v3 2/5] uaccess: Use user_access_ok() in user_access_begin() Masami Hiramatsu
2019-02-27 14:43 ` [PATCH v3 3/5] uaccess: Add non-pagefault user-space read functions Masami Hiramatsu
2019-02-27 14:44 ` [PATCH v3 4/5] tracing/probe: Add ustring type for user-space string Masami Hiramatsu
2019-02-28 2:20 ` Steven Rostedt
2019-02-27 14:44 ` [PATCH v3 5/5] tracing/probe: Support user-space dereference Masami Hiramatsu
2019-02-28 2:31 ` Steven Rostedt
2019-02-28 7:00 ` Masami Hiramatsu
2019-02-28 16:20 ` Steven Rostedt
2019-02-28 2:42 ` Steven Rostedt
2019-02-28 6:08 ` Masami Hiramatsu
2019-02-27 22:32 ` [PATCH v3 0/5] tracing/probes: uaccess: Add support user-space access Alexei Starovoitov
2019-02-28 1:54 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228105431.ca1fbf6ae6fca15de2f17c22@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=changbin.du@gmail.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).