From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mans Rullgard <mans@mansr.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] dt-bindings: usb: add non-removable device property
Date: Thu, 28 Feb 2019 16:13:30 +0100 [thread overview]
Message-ID: <20190228151330.GA1360@kroah.com> (raw)
In-Reply-To: <20190228143344.16312-1-mans@mansr.com>
On Thu, Feb 28, 2019 at 02:33:44PM +0000, Mans Rullgard wrote:
> Add a boolean property indicating that a device is hardwired to the
> upstream port. Although hubs can provide this information, they are not
> always configured correctly. An alternate means of indicating this for
> built-in USB devices is thus useful.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> I have a situation where userspace would like to know which USB devices
> are built-in, but the on-board hub doesn't have the right setting.
> Also, the hub itself can't be indicated as fixed in any other way that
> I'm aware of.
Then that's a firmware bug, right? We have a way for firmware to export
this to the USB core, why not use that? Your on-board hub should get a
firmware update with this information, let's not try to create
yet-another-way to define this type of information please.
> In a way, adding this property seems a bit silly since dt can only
> sensibly be used for hardwired devices in the first place. Thus the
> mere presence of a dt node could be taken to indicate the same thing.
> On the other hand, it's conceivable that someone might dynamically
> generate a devicetree based on what happens to be connected on boot or
> something. For that reason, and explicit property seems safer.
> ---
> Documentation/devicetree/bindings/usb/usb-device.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
Can you show some code actually using this? Again, this should "just
work" for USB today unless your platform is really broken (and if it is,
go complain to the vendor...)
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-28 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 14:33 [RFC][PATCH] dt-bindings: usb: add non-removable device property Mans Rullgard
2019-02-28 15:13 ` Greg Kroah-Hartman [this message]
2019-02-28 15:22 ` Måns Rullgård
2019-02-28 15:52 ` Greg Kroah-Hartman
2019-02-28 17:34 ` Måns Rullgård
2019-02-28 18:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228151330.GA1360@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mans@mansr.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).