From: Qian Cai <cai@lca.pw>
To: peterz@infradead.org, mingo@redhat.com, will.deacon@arm.com
Cc: bvanassche@acm.org, longman@redhat.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, Qian Cai <cai@lca.pw>
Subject: [PATCH -next] lockdep: skip debugobjects for lock_classes[] init
Date: Sat, 2 Mar 2019 23:02:24 -0500 [thread overview]
Message-ID: <20190303040224.7666-1-cai@lca.pw> (raw)
The linux-next commit a0b0fd53e1e6 ("locking/lockdep: Free lock classes
that are no longer in use") let init_data_structures_once() call
init_rcu_head(). As the result, smp_setup_processor_id() calls
debug_object_init() before debug_objects_early_init() triggering errors
below on arm64 and ppc64le. Since debug_objects_early_init() depends on
smp_setup_processor_id(), so it is not straightforward to move the
former earlier in start_kernel(). Hence, just skip all debugobjects
creations in init_data_structures_once() as a good trade-off by losing
track of some RCU list heads debugging.
BUG: spinlock bad magic on CPU#0, swapper/0
lock: obj_hash+0xc3048/0x100000, .magic: 00000000, .owner: <none>/-1,
.owner_cpu: 0
CPU: 0 PID: 0 Comm: swapper Not tainted 5.0.0-rc8-next-20190301+ #1
Call trace:
dump_backtrace+0x0/0x450
show_stack+0x20/0x2c
dump_stack+0xe0/0x16c
spin_bug+0x200/0x224
do_raw_spin_lock+0x1bc/0x23c
_raw_spin_lock_irqsave+0xac/0xd0
__debug_object_init+0xf0/0x19dc
debug_object_init+0x54/0x6c
init_rcu_head+0x24/0x30
init_data_structures_once+0xb0/0x41c
register_lock_class+0x70c/0x1454
__lock_acquire+0xc4/0x235c
lock_acquire+0x508/0x668
_raw_spin_lock+0x88/0xac
vprintk_emit+0x33c/0x53c
vprintk_default+0x54/0x7c
vprintk_func+0x320/0x40c
printk+0x64/0x8c
smp_setup_processor_id+0x6c/0x84
start_kernel+0x38/0x8f8
ODEBUG: Out of memory. ODEBUG disabled
Signed-off-by: Qian Cai <cai@lca.pw>
---
kernel/locking/lockdep.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 21cb81fe6359..1309a6fe88ee 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -988,7 +988,6 @@ static void init_data_structures_once(void)
initialization_happened = true;
- init_rcu_head(&delayed_free.rcu_head);
INIT_LIST_HEAD(&delayed_free.pf[0].zapped);
INIT_LIST_HEAD(&delayed_free.pf[1].zapped);
--
2.17.2 (Apple Git-113)
next reply other threads:[~2019-03-03 4:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 4:02 Qian Cai [this message]
2019-03-03 18:19 ` [PATCH -next] lockdep: skip debugobjects for lock_classes[] init Bart Van Assche
2019-03-04 3:06 ` Qian Cai
2019-03-09 14:41 ` [tip:locking/urgent] locking/lockdep: Only call init_rcu_head() after RCU has been initialized tip-bot for Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190303040224.7666-1-cai@lca.pw \
--to=cai@lca.pw \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).