From: Jonathan Cameron <jic23@kernel.org>
To: Anderson Reis <andersonreisrosa@gmail.com>
Cc: Tomasz Duszynski <tduszyns@gmail.com>,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
matt.ranostay@konsulko.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com,
Lucas Oshiro <lucasseikioshiro@gmail.com>
Subject: Re: [PATCH v2 1/4] iio:potentiostat:lmp91000: remove unnecessary parentheses
Date: Sat, 9 Mar 2019 18:44:29 +0000 [thread overview]
Message-ID: <20190309184429.5af90912@archlinux> (raw)
In-Reply-To: <CAJut9009qPt50o4CDNpkZ=NQVetivYHJMi2pY_DrDUk=WN=XMw@mail.gmail.com>
On Fri, 8 Mar 2019 19:26:16 -0300
Anderson Reis <andersonreisrosa@gmail.com> wrote:
> Hi, Tomasz
>
> thanks for the guidance.
Applied with the description tweaked.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
>
>
>
> On Fri, Mar 8, 2019, 18:04 Tomasz Duszynski <tduszyns@gmail.com> wrote:
>
> > On Fri, Mar 08, 2019 at 04:46:52PM -0300, Anderson Reis wrote:
> > > From: Lucas Oshiro <lucasseikioshiro@gmail.com>
> > >
> > > Remove unnecessary parentheses on line 116, and solve these
> > checkpatch.pl
> >
> > No need to explicitly point finger at changed lines. This is what
> > context lines are for.
> >
> > > CHECKs:
> > >
> > > - lmp91000.c:116: CHECK: Unnecessary parentheses around 'state !=
> > channel'
> > > - lmp91000.c:116: CHECK: Unnecessary parentheses around 'channel ==
> > LMP91000_REG_MODECN_TEMP'
> > >
> > > Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
> > > Signed-off-by: Anderson Reis <andersonreisrosa@gmail.com>
> > > ---
> > > drivers/iio/potentiostat/lmp91000.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/potentiostat/lmp91000.c
> > b/drivers/iio/potentiostat/lmp91000.c
> > > index 90e895adf997..03d277621861 100644
> > > --- a/drivers/iio/potentiostat/lmp91000.c
> > > +++ b/drivers/iio/potentiostat/lmp91000.c
> > > @@ -113,7 +113,7 @@ static int lmp91000_read(struct lmp91000_data *data,
> > int channel, int *val)
> > > return -EINVAL;
> > >
> > > /* delay till first temperature reading is complete */
> > > - if ((state != channel) && (channel == LMP91000_REG_MODECN_TEMP))
> > > + if (state != channel && channel == LMP91000_REG_MODECN_TEMP)
> > > usleep_range(3000, 4000);
> > >
> > > data->chan_select = channel != LMP91000_REG_MODECN_3LEAD;
> > > --
> > > 2.20.1
> > >
> >
next prev parent reply other threads:[~2019-03-09 18:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 19:46 [PATCH v2 0/4] iio:potentiostat:lmp91000: Adjust codestyle, and minor cleanup changes Anderson Reis
2019-03-08 19:46 ` [PATCH v2 1/4] iio:potentiostat:lmp91000: remove unnecessary parentheses Anderson Reis
2019-03-08 21:04 ` Tomasz Duszynski
[not found] ` <CAJut9009qPt50o4CDNpkZ=NQVetivYHJMi2pY_DrDUk=WN=XMw@mail.gmail.com>
2019-03-09 18:44 ` Jonathan Cameron [this message]
2019-03-08 19:46 ` [PATCH v2 2/4] iio:potentiostat:lmp91000: reduce line width and remove blank line Anderson Reis
2019-03-09 18:45 ` Jonathan Cameron
2019-03-08 19:46 ` [PATCH v2 3/4] iio:potentiostat:lmp91000: invert if statement Anderson Reis
2019-03-09 18:46 ` Jonathan Cameron
2019-03-09 18:48 ` Jonathan Cameron
2019-03-08 19:46 ` [PATCH v2 4/4] iio:potentiostat:lmp91000: change dev_err message Anderson Reis
2019-03-09 18:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309184429.5af90912@archlinux \
--to=jic23@kernel.org \
--cc=andersonreisrosa@gmail.com \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucasseikioshiro@gmail.com \
--cc=matt.ranostay@konsulko.com \
--cc=pmeerw@pmeerw.net \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).