From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Tom Zanussi <zanussi@kernel.org>,
tglx@linutronix.de, namhyung@kernel.org, bigeasy@linutronix.de,
joel@joelfernandes.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: Re: [RFC PATCH 4/7] tracing/probe: Check event/group naming rule at parsing
Date: Wed, 13 Mar 2019 11:23:46 -0400 [thread overview]
Message-ID: <20190313112346.0b3fc25f@gandalf.local.home> (raw)
In-Reply-To: <20190314000402.3b14693f9030e891648124f1@kernel.org>
On Thu, 14 Mar 2019 00:04:02 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > > strlcpy(buf, event, slash - event + 1);
> > > + if (!is_good_name(buf)) {
> > > + pr_info("Group name must follow the rule of C identifier\n");
> >
> > What do you mean by "C identifier"?
>
> I meant "the naming rules of C language identifiers". It means
> that the name has to start with alphabet or "_" and only contain
> alphanumeric characters and "_". Does it clear?
> I couldn't think of a good word. maybe "naming convention"
> does not fit...
Ah, OK that now makes sense.
>
> Would you have any idea?
I think I was more confused by the way it was stated. What about saying:
"Group names must follow the same rules as C identifiers"
Saying "the rule of C identifiers" made me think more of "the rule of
law", and thought that this had something to do with rules of C
zealots, and those that identify with "C" ;-)
-- Steve
next prev parent reply other threads:[~2019-03-13 15:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 12:27 [RFC PATCH 0/7] tracing: Use common error_log with probe events Masami Hiramatsu
2019-03-13 12:27 ` [RFC PATCH 1/7] tracing/probe: Check maxactive error cases Masami Hiramatsu
2019-03-13 13:20 ` Steven Rostedt
2019-03-13 14:37 ` Masami Hiramatsu
2019-03-13 14:51 ` Steven Rostedt
2019-03-13 22:43 ` Masami Hiramatsu
2019-03-13 12:27 ` [RFC PATCH 2/7] tracing/probe: Check event name length correctly Masami Hiramatsu
2019-03-13 12:28 ` [RFC PATCH 3/7] tracing/probe: Check the size of argument name and body Masami Hiramatsu
2019-03-13 12:28 ` [RFC PATCH 4/7] tracing/probe: Check event/group naming rule at parsing Masami Hiramatsu
2019-03-13 13:23 ` Steven Rostedt
2019-03-13 15:04 ` Masami Hiramatsu
2019-03-13 15:23 ` Steven Rostedt [this message]
2019-03-13 22:47 ` Masami Hiramatsu
2019-03-13 12:28 ` [RFC PATCH 5/7] tracing/probe: Verify alloc_trace_*probe() result Masami Hiramatsu
2019-03-13 12:28 ` [RFC PATCH 6/7] tracing: Use tracing error_log with probe events Masami Hiramatsu
2019-03-13 12:28 ` [RFC PATCH 7/7] selftests/ftrace: Add error_log testcase for kprobe errors Masami Hiramatsu
2019-03-13 20:15 ` [RFC PATCH 0/7] tracing: Use common error_log with probe events Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313112346.0b3fc25f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).