From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: ratelimit API: was: [RFC PATCH] printk: Introduce "store now but print later" prefix.
Date: Thu, 21 Mar 2019 09:49:40 +0100 [thread overview]
Message-ID: <20190321084940.GL8696@dhcp22.suse.cz> (raw)
In-Reply-To: <0316a449-e7ef-7ca5-2569-f3f2ebebbde9@i-love.sakura.ne.jp>
On Thu 21-03-19 17:13:54, Tetsuo Handa wrote:
> On 2019/03/21 0:25, Petr Mladek wrote:
> >> This requires serialization among threads using "rs". I already
> >> proposed ratelimit_reset() for memcg's OOM problem at
> >> https://lkml.kernel.org/r/201810180246.w9I2koi3011358@www262.sakura.ne.jp
> >> but it was not accepted.
> >
> > IMHO, the main problem was that the patch tried to work around
> > the ratelimit API weakness by a custom code.
> >
> > I believe that using an improved/extended ratelimit API with
> > a sane semantic would be more acceptable.
> >
>
> Michal, are you OK to use ratelimit_reset() in out_of_memory()
> if ratelimit_reset() is accepted?
I do not know what ratelimit_reset is but if that is a new API for
a more reasonable ratelimiting then sure, I do not have any objections.
I have been objecting to one-off hacks to workaround problems of the
existing api.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2019-03-21 8:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 4:42 [RFC PATCH] printk: Introduce "store now but print later" prefix Tetsuo Handa
2019-03-04 3:22 ` Sergey Senozhatsky
2019-03-04 11:40 ` Tetsuo Handa
2019-03-04 12:09 ` Sergey Senozhatsky
2019-03-04 14:23 ` Petr Mladek
2019-03-04 14:37 ` Sergey Senozhatsky
2019-03-05 1:23 ` Tetsuo Handa
2019-03-05 7:52 ` Sergey Senozhatsky
2019-03-05 12:57 ` Michal Hocko
2019-03-06 10:04 ` Petr Mladek
2019-03-06 14:27 ` Sergey Senozhatsky
2019-03-06 18:24 ` Tetsuo Handa
2019-03-15 10:49 ` Tetsuo Handa
2019-03-20 15:04 ` Petr Mladek
2019-03-20 15:25 ` ratelimit API: was: " Petr Mladek
2019-03-21 8:13 ` Tetsuo Handa
2019-03-21 8:49 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321084940.GL8696@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).