linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kimberly Brown <kimbrownkd@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kobject: Add support for default attribute groups to kobj_type
Date: Sat, 23 Mar 2019 07:07:37 +0100	[thread overview]
Message-ID: <20190323060737.GA28563@kroah.com> (raw)
In-Reply-To: <20190322201440.GA30814@ubu-Virtual-Machine>

On Fri, Mar 22, 2019 at 04:14:40PM -0400, Kimberly Brown wrote:
> kobj_type currently uses a list of individual attributes to store
> default attributes. Attribute groups are more flexible than a list of
> attributes because groups provide support for attribute visibility. So,
> add support for default attribute groups to kobj_type.
> 
> In future patches, the existing uses of kobj_type’s attribute list will
> be converted to attribute groups. When that is complete, kobj_type’s
> attribute list, “default_attrs”, will be removed.
> 
> Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
> ---
>  include/linux/kobject.h |  3 ++-
>  lib/kobject.c           | 14 ++++++++++++++
>  2 files changed, 16 insertions(+), 1 deletion(-)

Yes!  Thanks for doing this.

But how did you test it?  Did you convert any kobj_type structures to
the attribute group and see that all was the same?  Ideally I'd like to
take this patch with at least one subsystem that uses the change,
otherwise this looks like unused code in the kernel.

thanks,

greg k-h

  reply	other threads:[~2019-03-23  6:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 20:14 [PATCH] kobject: Add support for default attribute groups to kobj_type Kimberly Brown
2019-03-23  6:07 ` Greg Kroah-Hartman [this message]
2019-03-24  3:48   ` Kimberly Brown
2019-03-24  5:15     ` Greg Kroah-Hartman
2019-04-02  2:51 ` [PATCH v2 0/8] kobject: Add default group support to kobj_type and replace subsystem uses Kimberly Brown
2019-04-02  2:51   ` [PATCH v2 1/8] kobject: Add support for default attribute groups to kobj_type Kimberly Brown
2019-04-02  2:51   ` [PATCH v2 2/8] samples/kobject: Replace foo_ktype's default_attrs field with groups Kimberly Brown
2019-04-02  2:51   ` [PATCH v2 3/8] block: Replace all ktype default_attrs " Kimberly Brown
2019-04-02 16:02     ` Bart Van Assche
2019-04-02 17:46       ` Greg Kroah-Hartman
2019-04-02 18:06         ` Bart Van Assche
2019-04-02  2:51   ` [PATCH v2 4/8] net-sysfs: Replace ktype default_attrs field " Kimberly Brown
2019-04-02  2:51   ` [PATCH v2 5/8] irqdesc: Replace irq_kobj_type's " Kimberly Brown
2019-04-02  8:04     ` Thomas Gleixner
2019-04-02  2:51   ` [PATCH v2 6/8] padata: Replace padata_attr_type " Kimberly Brown
2019-04-02  2:51   ` [PATCH v2 7/8] cpufreq: schedutil: Replace " Kimberly Brown
2019-04-02  7:56     ` Rafael J. Wysocki
2019-04-02  8:50     ` Peter Zijlstra
2019-04-02  2:51   ` [PATCH v2 8/8] livepatch: Replace klp_ktype_patch's default_attrs " Kimberly Brown
2019-04-02 10:22     ` Jiri Kosina
2019-04-03 11:51     ` Miroslav Benes
2019-04-08 14:16     ` Petr Mladek
2019-04-02  6:29   ` [PATCH v2 0/8] kobject: Add default group support to kobj_type and replace subsystem uses Greg Kroah-Hartman
2019-04-25 20:12   ` Greg Kroah-Hartman
2019-04-27  6:18     ` Kimberly Brown
2019-04-27  6:41       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190323060737.GA28563@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=kimbrownkd@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).