linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ojaswin Mujoo <ojaswin25111998@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Forest Bond <forest@alittletooquiet.net>
Subject: Re: [PATCH] drivers/staging: fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h
Date: Tue, 26 Mar 2019 04:38:51 +0900	[thread overview]
Message-ID: <20190325193851.GB27571@kroah.com> (raw)
In-Reply-To: <1553522934-7366-1-git-send-email-ojaswin25111998@gmail.com>

On Mon, Mar 25, 2019 at 07:36:53PM +0530, Ojaswin Mujoo wrote:
> From: ojaswin <ojaswin25111998@gmail.com>
> 
> Fix checkpatch.pl styling error related to SPDX-License-Identifier comment 
> in vt6656/*.h
> 
> Signed-off-by: Ojaswin Mujoo <ojaswin25111998@gmail.com>

This also has to match the "From:" line :)

And you have trailing whitespace in your changelog comment :(

And finally, when resending a patch, please properly "version" it, as
described in the Documentation for how to do this.

thanks,

greg k-h

      reply	other threads:[~2019-03-25 20:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-24 17:47 [PATCH] drivers/staging: fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h ojaswin
2019-03-24 19:57 ` Greg Kroah-Hartman
2019-03-25 14:06   ` Ojaswin Mujoo
2019-03-25 19:38     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190325193851.GB27571@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojaswin25111998@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).