linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Ibtsam Ul-Haq <ibtsam.haq.0x01@gmail.com>
Cc: jic23@kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: Add bindings for TI TLA202x ADCs
Date: Thu, 28 Mar 2019 13:38:42 -0500	[thread overview]
Message-ID: <20190328183842.GA9079@bogus> (raw)
In-Reply-To: <1553608583-29006-2-git-send-email-ibtsam.haq.0x01@gmail.com>

On Tue, Mar 26, 2019 at 02:56:20PM +0100, Ibtsam Ul-Haq wrote:
> This adds devicetree bindings for TI TLA202x ADCs.
> 
> Signed-off-by: Ibtsam Ul-Haq <ibtsam.haq.0x01@gmail.com>
> ---
>  .../devicetree/bindings/iio/adc/ti-tla2024.txt     | 45 ++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-tla2024.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-tla2024.txt b/Documentation/devicetree/bindings/iio/adc/ti-tla2024.txt
> new file mode 100644
> index 0000000..a4934df
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti-tla2024.txt
> @@ -0,0 +1,45 @@
> +Texas Instruments' TLA2021/TLA2022/TLA2024 12-bit ADC driver
> +
> +Required properties:
> +
> +- compatible: should be one of:
> +  "ti,tla2024"
> +  "ti,tla2022"
> +  "ti,tla2021"
> +
> +- reg: should contain the I2C Address of the device
> +
> +Required subnodes:
> +
> +The ADC channels are configured as subnodes of the ADC.
> +The channels can be single-ended or differential, the input pins are
> +also set in the subnode.
> +
> +Possible channels in TLA2024:
> +  single: <0>, <1>, <2>, <3>
> +  differential: <0 1>, <0 3>, <1 3>, <2 3>
> +
> +In TLA2021/TLA2022 only the differential channel <0 1> is allowed.
> +
> +Example:
> +
> +tla2024_0: adc0@49 {

adc@49

> +	compatible = "ti,tla2024";
> +	reg = <0x49>;
> +
> +	v0@0 {

Unit-address without 'reg' is not valid.

> +		single-channel = <0>;

Look at the common adc binding or adi,ad7124.txt for how to do 
multi-channel with differential channels.

> +	};
> +
> +	v1@1 {
> +		single-channel = <1>;
> +	};
> +
> +	v23@2 {
> +		diff-channels = <2 3>;
> +	};
> +
> +	v01@3 {
> +		diff-channels = <0 1>;
> +	};
> +};
> -- 
> 2.7.4
> 

  reply	other threads:[~2019-03-28 18:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 13:56 [PATCH v3 1/2] iio: Add driver for TLA202x ADCs Ibtsam Ul-Haq
2019-03-26 13:56 ` [PATCH v3 2/2] dt-bindings: iio: Add bindings for TI " Ibtsam Ul-Haq
2019-03-28 18:38   ` Rob Herring [this message]
2019-03-30 15:58     ` Jonathan Cameron
2019-03-30 16:00 ` [PATCH v3 1/2] iio: Add driver for " Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190328183842.GA9079@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ibtsam.haq.0x01@gmail.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).