From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18EFC4360F for ; Tue, 2 Apr 2019 09:54:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C454E208E4 for ; Tue, 2 Apr 2019 09:54:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729737AbfDBJyq convert rfc822-to-8bit (ORCPT ); Tue, 2 Apr 2019 05:54:46 -0400 Received: from tyo162.gate.nec.co.jp ([114.179.232.162]:44945 "EHLO tyo162.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727525AbfDBJyp (ORCPT ); Tue, 2 Apr 2019 05:54:45 -0400 Received: from mailgate02.nec.co.jp ([114.179.233.122]) by tyo162.gate.nec.co.jp (8.15.1/8.15.1) with ESMTPS id x329sLFR032474 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 2 Apr 2019 18:54:21 +0900 Received: from mailsv01.nec.co.jp (mailgate-v.nec.co.jp [10.204.236.94]) by mailgate02.nec.co.jp (8.15.1/8.15.1) with ESMTP id x329sLPQ006220; Tue, 2 Apr 2019 18:54:21 +0900 Received: from mail01b.kamome.nec.co.jp (mail01b.kamome.nec.co.jp [10.25.43.2]) by mailsv01.nec.co.jp (8.15.1/8.15.1) with ESMTP id x329r5wA015062; Tue, 2 Apr 2019 18:54:21 +0900 Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.138] [10.38.151.138]) by mail01b.kamome.nec.co.jp with ESMTP id BT-MMP-3907718; Tue, 2 Apr 2019 18:53:52 +0900 Received: from BPXM12GP.gisp.nec.co.jp ([10.38.151.204]) by BPXC10GP.gisp.nec.co.jp ([10.38.151.138]) with mapi id 14.03.0319.002; Tue, 2 Apr 2019 18:53:51 +0900 From: Junichi Nomura To: Chao Fan CC: Borislav Petkov , "bhe@redhat.com" , "Dave Young" , "kasong@redhat.com" , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Thread-Topic: [PATCH v2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Thread-Index: AQHU6TAPBuKir5aKdUeGLetpGKkWo6YoCrIA Date: Tue, 2 Apr 2019 09:53:51 +0000 Message-ID: <20190402095350.GA20733@jeru.linux.bs1.fc.nec.co.jp> References: <20190325123229.GL12016@zn.tnic> <20190325231000.GA9184@jeru.linux.bs1.fc.nec.co.jp> <20190326135714.GG1867@zn.tnic> <20190327014852.GA3659@MiWiFi-R3L-srv> <73322ba9-e436-68db-7863-afd31607d969@ce.jp.nec.com> <20190328064343.GA1877@MiWiFi-R3L-srv> <20190328074337.GA9470@jeru.linux.bs1.fc.nec.co.jp> <20190328155256.GP22720@zn.tnic> <20190401000837.GA5170@jeru.linux.bs1.fc.nec.co.jp> <20190402094149.GB1555@localhost.localdomain> In-Reply-To: <20190402094149.GB1555@localhost.localdomain> Accept-Language: en-US, ja-JP Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.34.125.85] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <86D499187EC21A4AA7AE510078A97754@gisp.nec.co.jp> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 02, 2019 at 05:41:49PM +0800, Chao Fan wrote: > [ 77.989030] kexec_core: Starting new kernel > early console in extract_kernel > input_data: 0x000000017f6033b1 > input_len: 0x00000000008412d4 > output: 0x000000017e000000 > output_len: 0x0000000001e15844 > kernel_total_size: 0x0000000001e2c000 > trampoline_32bit: 0x000000000009d000 > booted via startup_64() > > > Physical KASLR disabled: no suitable memory region! > ------ > > I am not sure whether I have done the right test. > This guest is booted from EFI. Here we can see the kexeced kernel > has completed the compressed boot stage. So I think your PATCH works. Thanks for testing. If your test bed doesn't boot even with the patch, you could check what was found as RSDP with a debug patch like below. diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c --- a/arch/x86/boot/compressed/misc.c +++ b/arch/x86/boot/compressed/misc.c @@ -379,6 +379,7 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap, debug_putaddr(output); debug_putaddr(output_len); debug_putaddr(kernel_total_size); + debug_putaddr(boot_params->acpi_rsdp_addr); #ifdef CONFIG_X86_64 /* Report address of 32-bit trampoline */