From: Lee Jones <lee.jones@linaro.org>
To: "Morris Ku 古文俊" <morris_ku@sunix.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Add support for SUNIX Multi-I/O board
Date: Wed, 3 Apr 2019 04:40:53 +0100 [thread overview]
Message-ID: <20190403034053.GJ4187@dell> (raw)
In-Reply-To: <HK2PR03MB45295EF1E814CE40BDFB798995560@HK2PR03MB4529.apcprd03.prod.outlook.com>
Please do not drop the list from your recipients.
On Tue, 02 Apr 2019, Morris Ku 古文俊 wrote:
> Hello , Lee ,
>
>
> Sunix multi-io card is a composite device,
> contains serial and parallel port , before we
> trying to place the driver in the /drivers/char,
> but maintainer suggests go to /driver/mfd,so we move to here.
> this driver is special,it supports more than one interface,
> so we combine to a single driver.
The MFD subsystem is designed to register child devices. MFD drivers
do not contain any true functionality themselves. If this device does
multiple things, you can split the functionality into their relevant
subsystems and register each of them from here.
There are 10's of examples available. Please take a look around some
of the existing drivers to see how their functionality is split.
> On Tue, 19 Mar 2019, Morris Ku wrote:
>
> > Driver for SUNIX Multi-I/O card.Based on parport_pc.c, ppdev.c
> > and lp.c by Linus Torvalds, Theodore Ts'o.
>
> Parallel port drivers should live in 'drivers/parport' and
> 'drivers/char'. LP drivers should live in 'drivers/char'.
>
> Please them there.
>
> > Signed-off-by: Morris Ku <saumah@gmail.com>
> > ---
> > mfd/sunix/snx_ieee1284.c | 144 +++++++
> > mfd/sunix/snx_ieee1284_ops.c | 258 +++++++++++++
> > mfd/sunix/snx_lp.c | 717 +++++++++++++++++++++++++++++++++++
> > mfd/sunix/snx_lp.h | 119 ++++++
> > mfd/sunix/snx_parallel.c | 397 +++++++++++++++++++
> > mfd/sunix/snx_ppdev.c | 454 ++++++++++++++++++++++
> > mfd/sunix/snx_ppdev.h | 15 +
> > mfd/sunix/snx_share.c | 629 ++++++++++++++++++++++++++++++
> > 8 files changed, 2733 insertions(+)
> > create mode 100644 mfd/sunix/snx_ieee1284.c
> > create mode 100644 mfd/sunix/snx_ieee1284_ops.c
> > create mode 100644 mfd/sunix/snx_lp.c
> > create mode 100644 mfd/sunix/snx_lp.h
> > create mode 100644 mfd/sunix/snx_parallel.c
> > create mode 100644 mfd/sunix/snx_ppdev.c
> > create mode 100644 mfd/sunix/snx_ppdev.h
> > create mode 100644 mfd/sunix/snx_share.c
>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2019-04-03 3:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 12:08 [PATCH 4/4] Add support for SUNIX Multi-I/O board Morris Ku
2019-03-22 16:55 ` Enrico Weigelt, metux IT consult
2019-04-02 6:26 ` Lee Jones
[not found] ` <HK2PR03MB45295EF1E814CE40BDFB798995560@HK2PR03MB4529.apcprd03.prod.outlook.com>
2019-04-03 3:40 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403034053.GJ4187@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morris_ku@sunix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).