From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2888BC10F0E for ; Tue, 9 Apr 2019 14:18:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F254320883 for ; Tue, 9 Apr 2019 14:18:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbfDIOSI (ORCPT ); Tue, 9 Apr 2019 10:18:08 -0400 Received: from muru.com ([72.249.23.125]:44966 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfDIOSI (ORCPT ); Tue, 9 Apr 2019 10:18:08 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D205E8027; Tue, 9 Apr 2019 14:18:21 +0000 (UTC) Date: Tue, 9 Apr 2019 07:17:59 -0700 From: Tony Lindgren To: Masahiro Yamada Cc: Keerthy , arm-soc , Olof Johansson , Arnd Bergmann , linux-arm-kernel , Linux-OMAP , Russell King , Linux Kernel Mailing List , Dave Gerlach Subject: Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2 Message-ID: <20190409141759.GA2839@atomide.com> References: <20190408075427.6052-1-yamada.masahiro@socionext.com> <20190408075427.6052-3-yamada.masahiro@socionext.com> <20190408161802.GI49658@atomide.com> <6308904e-443a-46ff-9633-2ccb3b03bef9@ti.com> <39d9cc92-ef2f-993c-3abd-99b134e1c22e@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Masahiro Yamada [190409 07:06]: > On Tue, Apr 9, 2019 at 2:17 PM Keerthy wrote: > > > > > > > > On 09/04/19 10:37 AM, Masahiro Yamada wrote: > > > On Tue, Apr 9, 2019 at 2:00 PM Keerthy wrote: > > >> > > >> > > >> > > >> On 08/04/19 9:48 PM, Tony Lindgren wrote: > > >>> Hi, > > >>> > > >>> * Masahiro Yamada [190408 07:56]: > > >>>> is only generated and included > > >>>> by arch/arm/mach-omap2/, so it does not need to reside in the > > >>>> globally visible include/generated/. > > >>>> > > >>>> I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h > > >>>> since the prefix 'omap2-' is just redundant in mach-omap2/. > > >>>> > > >>>> Signed-off-by: Masahiro Yamada > > >>>> --- > > >>>> > > >>>> Can this be applied to ARM-SOC tree in a series? > > >>>> (with Ack from the platform sub-maintainer.) > > >>>> > > >>>> ti-pm-asm-offsets.h does not need to reside in include/generated/, > > >>>> but you may ask "Why must it get out of include/generated/?" > > >>>> > > >>>> My main motivation is to avoid a race condition in the currently > > >>>> proposed patch: > > >>>> > > >>>> https://lore.kernel.org/patchwork/patch/1052763/ > > >>>> > > >>>> This patch tries to embed some build artifacts into the kernel. > > >>>> > > >>>> If arch/arm/mach-omap2/ and kernel/ are built at the same time, > > >>>> it may embed a truncated file. > > >>> > > >>> Looks like a nice improvment to me, adding Keerthy and Dave to Cc. > > >>> > > >>> Keerthy and Dave, can you please test this series with am3 and am4 > > >>> PM code? > > >> > > >> Tested for Deep Sleep0 on AM33xx Beaglebone-black. > > >> Tested for Deep Sleep0 on AM437x-gp-evm. > > >> > > >> Applied this on top of Tony's for-next with the gpio patch > > >> required for RTC+DDR mode on am437x-gp-evm. > > > > > > Was it applied to TI tree? > > > > > > If so ... > > > > > > Arnd, Olof, > > > Please just ignore this patch > > > since it looks it was already applied to TI tree. > > > > Masahiro Yamada, > > > > No i manually applied this on top. > > > > Regards, > > Keerthy > > Keerthy, > Sorry, I misunderstood. > > You just applied it to your local tree for testing. > > Then, I still think it is better to > apply this series in a correct order. > > The reason I sent this in a series was > to make sure asm-offset headers are correctly > cleaned up. Yes looks good to me: Acked-by: Tony Lindgren