From: David Miller <davem@davemloft.net>
To: linux@roeck-us.net
Cc: neilb@suse.com, tgraf@suug.ch, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Fix rhashtable bit-locking for m68k
Date: Fri, 12 Apr 2019 17:34:58 -0700 (PDT) [thread overview]
Message-ID: <20190412.173458.2194302001630174696.davem@davemloft.net> (raw)
In-Reply-To: <db89e10c-44ba-117d-2fe3-e01eb733d29a@roeck-us.net>
From: Guenter Roeck <linux@roeck-us.net>
Date: Fri, 12 Apr 2019 11:08:41 -0700
> On 4/11/19 6:52 PM, NeilBrown wrote:
>> As reported by Guenter Roeck, the new rhashtable bit-locking
>> doesn't work on m68k as it only requires 2-byte alignment, so BIT(1)
>> is addresses is not unused.
>> We current use BIT(0) to identify a NULLS marker, but that is only
>> needed in ->next pointers. The bucket head does not need a NULLS
>> marker, so the lsb there can be used for locking.
>> the first 4 patches make some small improvements and re-arrange some
>> code. The final patch converts to using only BIT(0) for these two
>> different special purposes.
>> I had previously suggested dropping the series until I fix it. Given
>> that this was fairly easy, I retract that I think it best simply to
>> add these patches to fix the code.
>>
> For the series:
>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
Series applied.
prev parent reply other threads:[~2019-04-13 0:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 1:52 [PATCH 0/5] Fix rhashtable bit-locking for m68k NeilBrown
2019-04-12 1:52 ` [PATCH 1/5] rhashtable: fix some __rcu annotation errors NeilBrown
2019-04-12 1:52 ` [PATCH 5/5] rhashtable: use BIT(0) for locking NeilBrown
2019-04-12 1:52 ` [PATCH 2/5] rhashtable: reorder some inline functions and macros NeilBrown
2019-05-14 19:25 ` Jakub Kicinski
2019-04-12 1:52 ` [PATCH 4/5] rhashtable: replace rht_ptr_locked() with rht_assign_locked() NeilBrown
2019-04-12 1:52 ` [PATCH 3/5] rhashtable: move dereference inside rht_ptr() NeilBrown
2019-04-12 18:08 ` [PATCH 0/5] Fix rhashtable bit-locking for m68k Guenter Roeck
2019-04-13 0:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412.173458.2194302001630174696.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=neilb@suse.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).