From: Oscar Salvador <osalvador@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org, Michal Hocko <mhocko@suse.com>,
Vlastimil Babka <vbabka@suse.cz>,
Logan Gunthorpe <logang@deltatee.com>,
linux-mm@kvack.org, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, david@redhat.com
Subject: Re: [PATCH v6 04/12] mm/hotplug: Prepare shrink_{zone, pgdat}_span for sub-section removal
Date: Fri, 26 Apr 2019 16:00:11 +0200 [thread overview]
Message-ID: <20190426140011.GB30513@linux> (raw)
In-Reply-To: <20190426135907.GA30513@linux>
On Fri, Apr 26, 2019 at 03:59:12PM +0200, Oscar Salvador wrote:
> On Wed, Apr 17, 2019 at 11:39:16AM -0700, Dan Williams wrote:
> > @@ -417,10 +417,10 @@ static void shrink_zone_span(struct zone *zone, unsigned long start_pfn,
> > * it check the zone has only hole or not.
> > */
> > pfn = zone_start_pfn;
> > - for (; pfn < zone_end_pfn; pfn += PAGES_PER_SECTION) {
> > + for (; pfn < zone_end_pfn; pfn += PAGES_PER_SUB_SECTION) {
> > ms = __pfn_to_section(pfn);
> >
> > - if (unlikely(!valid_section(ms)))
> > + if (unlikely(!pfn_valid(pfn)))
> > continue;
> >
> > if (page_zone(pfn_to_page(pfn)) != zone)
> > @@ -485,10 +485,10 @@ static void shrink_pgdat_span(struct pglist_data *pgdat,
> > * has only hole or not.
> > */
> > pfn = pgdat_start_pfn;
> > - for (; pfn < pgdat_end_pfn; pfn += PAGES_PER_SECTION) {
> > + for (; pfn < pgdat_end_pfn; pfn += PAGES_PER_SUB_SECTION) {
> > ms = __pfn_to_section(pfn);
> >
> > - if (unlikely(!valid_section(ms)))
> > + if (unlikely(!pfn_valid(pfn)))
> > continue;
> >
> > if (pfn_to_nid(pfn) != nid)
>
> The last loop from shrink_{pgdat,zone}_span can be reworked to unify both
> in one function, and both functions can be factored out a bit.
> Actually, I do have a patch that does that, I might dig it up.
>
> The rest looks good:
>
> Reviewed-by: Oscar Salvador <osalvador@suse.de>
I mean of course besides Ralph's comment.
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2019-04-26 14:00 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 18:38 [PATCH v6 00/12] mm: Sub-section memory hotplug support Dan Williams
2019-04-17 18:39 ` [PATCH v6 01/12] mm/sparsemem: Introduce struct mem_section_usage Dan Williams
2019-05-01 23:25 ` Pavel Tatashin
2019-05-02 6:07 ` Dan Williams
2019-05-02 14:16 ` Pavel Tatashin
2019-05-04 0:22 ` Dan Williams
2019-05-04 15:55 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section Dan Williams
2019-05-02 14:53 ` Pavel Tatashin
2019-05-03 0:41 ` Dan Williams
2019-05-03 10:35 ` Robin Murphy
2019-05-03 12:57 ` Pavel Tatashin
2019-05-03 13:00 ` Oscar Salvador
2019-04-17 18:39 ` [PATCH v6 03/12] mm/sparsemem: Add helpers track active portions of a section at boot Dan Williams
2019-04-25 14:33 ` Oscar Salvador
2019-04-25 14:43 ` Oscar Salvador
2019-04-26 12:57 ` Oscar Salvador
2019-05-02 16:12 ` Pavel Tatashin
2019-05-04 19:26 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 04/12] mm/hotplug: Prepare shrink_{zone, pgdat}_span for sub-section removal Dan Williams
2019-04-19 23:09 ` Ralph Campbell
2019-04-19 23:13 ` Dan Williams
2019-04-26 13:59 ` Oscar Salvador
2019-04-26 14:00 ` Oscar Salvador [this message]
2019-05-02 19:18 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 05/12] mm/sparsemem: Convert kmalloc_section_memmap() to populate_section_memmap() Dan Williams
2019-05-02 19:28 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 06/12] mm/hotplug: Add mem-hotplug restrictions for remove_memory() Dan Williams
2019-04-23 21:21 ` David Hildenbrand
2019-04-24 18:07 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 07/12] mm: Kill is_dev_zone() helper Dan Williams
2019-04-17 20:17 ` David Hildenbrand
2019-04-26 14:04 ` Oscar Salvador
2019-05-02 20:37 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 08/12] mm/sparsemem: Prepare for sub-section ranges Dan Williams
2019-05-02 21:25 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 09/12] mm/sparsemem: Support sub-section hotplug Dan Williams
2019-04-17 18:39 ` [PATCH v6 10/12] mm/devm_memremap_pages: Enable sub-section remap Dan Williams
2019-04-17 18:39 ` [PATCH v6 11/12] libnvdimm/pfn: Fix fsdax-mode namespace info-block zero-fields Dan Williams
2019-04-17 22:02 ` Andrew Morton
2019-04-17 22:09 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 12/12] libnvdimm/pfn: Stop padding pmem namespaces to section alignment Dan Williams
2019-04-17 22:03 ` [PATCH v6 00/12] mm: Sub-section memory hotplug support Andrew Morton
2019-04-17 22:59 ` Dan Williams
2019-04-18 2:09 ` Dan Williams
2019-04-18 12:45 ` Jeff Moyer
2019-04-19 3:25 ` Dan Williams
2019-04-23 13:16 ` Oscar Salvador
2019-04-24 20:43 ` Pavel Tatashin
2019-05-02 22:46 ` Pavel Tatashin
2019-05-02 23:20 ` Dan Williams
2019-05-02 23:21 ` Dan Williams
2019-05-03 10:48 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426140011.GB30513@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).